New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable dismissing with edge pan gesture #838

Merged
merged 1 commit into from Sep 7, 2016

Conversation

Projects
None yet
2 participants
@chuganzy
Contributor

chuganzy commented Aug 27, 2016

SFSafariViewController's container VC is dismissed unexpectedly when swiping the screen edge.

By dismissing with that way, SFSafariViewControllerDelegate's -(void)safariViewControllerDidFinish: is not invoked even though FBSDKContainerViewControllerDelegate's -(void)viewControllerDidDisappear: is invoked, so the error log in -(void)viewControllerDidDisappear: appears.

@ghost ghost added the CLA Signed label Aug 27, 2016

@chrisp-fb chrisp-fb merged commit a0a9fbf into facebook:dev Sep 7, 2016

@chrisp-fb

This comment has been minimized.

Show comment
Hide comment
@chrisp-fb

chrisp-fb Sep 7, 2016

Contributor

Thanks!

Contributor

chrisp-fb commented Sep 7, 2016

Thanks!

@chuganzy chuganzy deleted the chuganzy:fix-unexpected-dismiss branch Dec 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment