Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Carthage to create a single archive #990

Closed
wants to merge 1 commit into from

Conversation

@JosephDuffy
Copy link
Contributor

JosephDuffy commented May 14, 2019

Carthage expects a single .zip file containing all frameworks for all platforms. The current method means that only the FBSDKCoreKit framework will be downloaded (when not using --no-use-binaries), this should allow them to all be downloaded automatically by Carthage.


Thanks for proposing a pull request.

To help us review the request, please complete the following:

Carthage expects a single .zip file containing all frameworks for all platforms. The current method means that only the FBSDKCoreKit framework will be downloaded (when not using `--no-use-binaries`), this should allow them to all be downloaded automatically by Carthage.
Copy link

facebook-github-bot left a comment

@dreamolight has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented May 21, 2019

@dreamolight merged this pull request in ec3a763.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.