Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__jsonArrayToShape removed from codegen but not runtime #350

Open
renaudb opened this issue Aug 19, 2019 · 0 comments

Comments

@renaudb
Copy link

commented Aug 19, 2019

__jsonArrayToShape was removed from the Hack codegen:

1462eb8

But it is still referenced in the Hack runtime:

https://github.com/facebook/fbthrift/blob/master/thrift/lib/hack/src/IThriftShapishStruct.php#L22

This leads to invalid code when running the Hack codegen with the shapes flag.

@renaudb renaudb changed the title __jsonArrayToShape removed from codegen, but not runtime __jsonArrayToShape removed from codegen but not runtime Aug 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.