[iOS]Crash reporting plugin #322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
iOS/Sample/NetworkViewController.m
Outdated
| @@ -17,6 +17,8 @@ @implementation NetworkViewController | |||
| - (void)viewDidLoad { | |||
| [super viewDidLoad]; | |||
| self.navigationItem.title = @"Network"; | |||
| NSArray *array = @[]; | |||
| [array objectAtIndex:4]; | |||
There was a problem hiding this comment.
This is added deliberately to cause a crash. I will remove it once I am done with my final changes.
There was a problem hiding this comment.
@priteshrnandgaonkar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@priteshrnandgaonkar has updated the pull request. Re-import the pull request |
priteshrnandgaonkar
changed the title
There was a problem hiding this comment.
@priteshrnandgaonkar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 26, 2018
Summary: This PR adds the barebone of a crash reporting plugin in android. Since there is no easy way to stack the PR's in git, creating a new PR, but this depends on the [iOS PR](#322) Pull Request resolved: #328 Reviewed By: jknoxville, passy Differential Revision: D13137447 Pulled By: priteshrnandgaonkar fbshipit-source-id: 3b86cebbb1ea01601405dd7ba58e1caa2b506065
|
It got merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A barebone of a crash reporting plugin. It catches the crash which may happen in iOS app and would send the crash stack as a message to the desktop app.
A screenshot of the message looks like the following
