Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document empty type #4090

Closed
danwang opened this issue Jun 2, 2017 · 7 comments
Closed

Document empty type #4090

danwang opened this issue Jun 2, 2017 · 7 comments
Labels
Accepting PRs Has PR help wanted Extra attention is needed Needs docs

Comments

@danwang
Copy link

danwang commented Jun 2, 2017

No description provided.

@roryokane
Copy link
Contributor

The empty type is described in #2225, the issue that asked for it to be implemented. It’s a “type that is not satisfied by any value”. It’s the equivalent of never in TypeScript.

@wuweiweiwu
Copy link

@samwgoldman @roryokane Can i take this?

@hokennethk hokennethk mentioned this issue Mar 15, 2018
Open
@reyronald
Copy link
Contributor

@wuweiweiwu Are you still interested in taking this? Would love to see it documented ❤️ !

I use it because I stumbled upon it on the web, was very surprised when I just noticed that it wasn't actually documented on the site :(

@goodmind goodmind mentioned this issue Apr 20, 2019
Closed
@rpivo
Copy link

rpivo commented Dec 8, 2020

What's the status of this? It looks like there is an open PR that was never merged. I'd be happy to work more on this if it's needed.

facebook-github-bot pushed a commit that referenced this issue Jan 4, 2023
@gkz @facebook-github-bot
[website] Add documentation for empty type
d85e953 
Summary:
Somehow, we did not have any documentation for the `empty` type. Add some.

Closes #4090
Closes #7655

Changelog: [internal]

Reviewed By: vdjeric, jbrown215

Differential Revision: D42183446

fbshipit-source-id: a0c3020ae82e4df131e4e0c785341981031111d8
@roryokane
Copy link
Contributor

The new documentation for the empty type is online at https://flow.org/en/docs/types/empty/.

@gkz
Copy link
Member

gkz commented Jan 8, 2023

Seems to have a bug rendering. I can fix that. The beta site renders fine in the meantime: https://beta.flow.org/en/docs/types/empty/

facebook-github-bot pushed a commit that referenced this issue Jan 9, 2023
@gkz @facebook-github-bot
[website] Fix rendering of empty docs on old website
cad9f25 
Summary:
Old website uses `// flow` rather than `js flow-check`. Hopefully soon we can get rid of the old website and not worry about stuff like this.

Changelog: [internal]

References #7655
References #4090

Reviewed By: SamChou19815

Differential Revision: D42419901

fbshipit-source-id: 89fe329085435ac8b9d3cbe2450f4d1ea6689460
@gkz
Copy link
Member

gkz commented Jan 10, 2023

Fixed with cad9f25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepting PRs Has PR help wanted Extra attention is needed Needs docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DOCS] Add Empty Types goodmind/flow
8 participants
@roryokane @samwgoldman @danwang @gkz @goodmind @reyronald @rpivo @wuweiweiwu