Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nested $Diff looses types in case of stateless functional react component #5652

Closed
villesau opened this issue Jan 13, 2018 · 1 comment
Closed

Comments

@villesau
Copy link
Contributor

villesau commented Jan 13, 2018

see this: broken example with stateless functional component

Flow should complain that passtrough property is missing but it doesn't.

However, if i change the component to class based, it works like it should:

working class based example

and if you take the other $Diff away, things start to work again:

example without double $Diff

This makes it impossible to write certain library definitions, like for react-redux.

@SamChou19815
Copy link
Contributor

The issue is fixed a while ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants