Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #114: add --no-flowlib option #151

Merged
merged 2 commits into from Dec 11, 2014

Conversation

Projects
None yet
3 participants
@ptmt
Copy link
Contributor

ptmt commented Nov 30, 2014

This is adds --no-flowlib option which allow to typecheck with ignoring default flow ./lib/*.js declarations.
Just a concept, would be awesome to have something like this, though I understand that implementation could be better or option should be renamed.

@gabelevi

This comment has been minimized.

Copy link
Contributor

gabelevi commented Dec 3, 2014

This makes sense to me, and the implementation looks good. I'd like @avikchaudhuri or @bhosmer to take a look before this is merged, though. I think they have a better sense of what other code might be making assumptions about flowlib. I do see some other places that call get_flowlib_root()

@tcoopman

This comment has been minimized.

Copy link
Contributor

tcoopman commented Dec 4, 2014

Maybe it would make sense to add this to .flowconfig too, now that it is possible to define the libs in the config.

@gabelevi

This comment has been minimized.

Copy link
Contributor

gabelevi commented Dec 11, 2014

Spoke to @bhosmer who's cool with this too. Merging...

gabelevi added a commit that referenced this pull request Dec 11, 2014

@gabelevi gabelevi merged commit 35c2a94 into facebook:master Dec 11, 2014

@ptmt

This comment has been minimized.

Copy link
Contributor Author

ptmt commented Dec 12, 2014

Wow, thank you! This inspires to do more.

On Thu, 11 Dec 2014 23:38 Gabe Levi notifications@github.com wrote:

Merged #151 #151.


Reply to this email directly or view it on GitHub
#151 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.