Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
add WebGL 1.0 types #2764
i've carefully followed https://www.khronos.org/registry/webgl/specs/latest/1.0/webgl.idl
there is one unperfect thing in my current definition:
does pass (it's a static field in the spec).
is valid and widely used code but won't work (property not found) because it's a static not part of the instance.
Should I duplicate the field in both the class and the instance, or is there a smart way?
BTW, this is exactly the same on
both should be valid
You have a number of failing tests: https://travis-ci.org/facebook/flow/jobs/173626828#L724
as far as I understand, the failing tests are just line number changes right?
It's all about file number changes in dom.js, because I added lines in that file.
- function type. Callable signature not found in. See lib: dom.js:1906 + function type. Callable signature not found in. See lib: dom.js:2789
I'll do it on my end, but to re-record those you just need to do:
# first: https://github.com/facebook/flow/tree/master#building-flow make build ./runtests.sh bin/flow # check that everything is just line number changes ./runtests.sh -r bin/flow # re-record tests ./runtests.sh bin/flow # check it again to make sure everything worked.