Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add React.StrictMode #6078

Closed
wants to merge 1 commit into from
Closed

Conversation

aweary
Copy link

@aweary aweary commented Apr 2, 2018

https://reactjs.org/docs/strict-mode.html

React.StrictMode has the same API as React.Fragment, a component that takes no props and renders its children.

StrictMode has the same API as React.Fragment: it's a component that
takes no props and renders its children.
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aweary has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@davidmccabe
Copy link

It looks like there's some kind of snapshot test that needs to be updated for this to land. @aweary Would you be so kind?

mxstbr added a commit to mxstbr/flow that referenced this pull request Oct 14, 2018
@mxstbr mxstbr mentioned this pull request Oct 14, 2018
@nmote nmote added the Library definitions Issues or pull requests about core library definitions label Jan 3, 2019
@jbrown215
Copy link
Contributor

Sorry for getting to this so late. This is in the libdefs already. I have a diff internally (expected to land in 0.92) that moves it to AbstractComponent

@jbrown215 jbrown215 closed this Jan 18, 2019
@goodmind goodmind added the Superseded PRs that solve the same issue as a "superseding" PR that already landed label Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Library definitions Issues or pull requests about core library definitions Superseded PRs that solve the same issue as a "superseding" PR that already landed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants