Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
add <PROJECT_ROOT> token support for node.resolve_dirname #7083
Overall this looks pretty reasonable. I'm not familiar with this option so I'll have to spend a bit of time reviewing to make sure I'm comfortable with this change.
If you are still interested in contributing, could you rebase and I'll take a closer look?
Also, it looks like the change to trim_lines is extraneous, could you either remove that change or split it out into a separate pull request?
Sorry for the delay here. If you decide to move forward, I'll personally make sure this gets reviewed.
@tanhauhau I just took a closer look and it looks like this option is already resolved relative to the project root. I put this line in my
A module I placed in the
What is the motivation for this change?
My main motivation is for my lerna based monorepo project setup:
dependencies within the project are symlinked, so you get:
in code_B, I imported
So, I wish to add
Hope it explains.
My point though is that Flow, today, appears to resolve these paths relative to the project root (that is, the location of the
It does not work previously when I made the PR, I need to check whether it works with the latest flow version as of today.…
On Fri, 11 Jan 2019, 01:03 Nat Mote ***@***.*** wrote: So are you thinking you would use <PROJECT_ROOT>/../pkgB/node_modules? Does simply writing ../pkgB/node_modules not have that effect today? <PROJECT_ROOT> will resolve to the location of the .flowconfig, which in your case would be pkgA/. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7083 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACOvSFB0FMg3G7H_rikGuR1jBat5U8hPks5vB3JYgaJpZM4X06-w> .