Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

FluxContainer: Unsafe lifecycle methods were found within a strict-mode tree #452

Open
satoshi-izawa opened this issue May 8, 2018 · 3 comments

Comments

@satoshi-izawa
Copy link

FluxContainer contains componentWillReceiveProps.
Does flux fix this problem?

@tiarebalbi
Copy link
Contributor

tiarebalbi commented May 25, 2018

I would say that this needs to be part of a big discussion as this problem can be fixed as part of a bigger change, adding support to React 16.4

screen shot 2018-05-25 at 5 44 12 pm

@kyldvs
Copy link
Contributor

kyldvs commented May 26, 2018

This will likely be addressed at some point within our version of FluxContainer at Facebook, but I do not know when that will be. At that time I can do a release with the appropriate changes, or if someone would like to contribute a PR sooner I'm happy to review!

@tiarebalbi
Copy link
Contributor

I'm reviewing the changes that are going to be required once I have the items I will raise an early PR for a review! Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants