diff --git a/README.md b/README.md index bc6c47473c9..bbaa2966edf 100644 --- a/README.md +++ b/README.md @@ -73,8 +73,15 @@ Folly is published on Github at https://github.com/facebook/folly folly requires gcc 4.8+ and a version of boost compiled with C++11 support. Please download googletest from -https://github.com/google/googletest/archive/release-1.7.0.zip and unzip it in the -folly/test subdirectory. +https://github.com/google/googletest/archive/release-1.8.0.tar.gz and unpack it into the +folly/test subdirectory as `gtest`: + + (cd folly/test && \ + rm -rf gtest && \ + wget https://github.com/google/googletest/archive/release-1.8.0.tar.gz && \ + tar zxf release-1.8.0.tar.gz && \ + rm -f release-1.8.0.tar.gz && \ + mv googletest-release-1.8.0 gtest) #### Ubuntu 12.04 diff --git a/folly/test/Makefile.am b/folly/test/Makefile.am index 409467e3959..9d983a3d692 100644 --- a/folly/test/Makefile.am +++ b/folly/test/Makefile.am @@ -2,7 +2,7 @@ SUBDIRS = . function_benchmark ACLOCAL_AMFLAGS = -I m4 -CPPFLAGS += -Igtest-1.7.0/include +CPPFLAGS += -isystem gtest/googletest/include -isystem gtest/googlemock/include TESTS= \ sorted_vector_types_test \ @@ -20,8 +20,8 @@ check_LTLIBRARIES = libfollytestmain.la libgtest.la check_PROGRAMS = noinst_LTLIBRARIES = thread_local_test_lib.la -libgtest_la_CPPFLAGS = -Igtest-1.7.0 -Igtest-1.7.0/src -libgtest_la_SOURCES = gtest-1.7.0/src/gtest-all.cc +libgtest_la_CPPFLAGS = -isystem gtest/googletest +libgtest_la_SOURCES = gtest/googletest/src/gtest-all.cc if FOLLY_TESTMAIN libfollytestmain_la_CPPFLAGS = $(AM_CPPFLAGS) $(libgtest_la_CPPFLAGS) @@ -29,7 +29,7 @@ libfollytestmain_la_SOURCES = $(libgtest_la_SOURCES) common/TestMain.cpp libfollytestmain_la_LIBADD = $(top_builddir)/init/libfollyinit.la $(top_builddir)/libfolly.la else libfollytestmain_la_CPPFLAGS = $(libgtest_la_CPPFLAGS) -libfollytestmain_la_SOURCES = $(libgtest_la_SOURCES) gtest-1.7.0/src/gtest_main.cc +libfollytestmain_la_SOURCES = $(libgtest_la_SOURCES) gtest/googletest/src/gtest_main.cc libfollytestmain_la_LIBADD = $(top_builddir)/libfolly.la endif