Permalink
Browse files

Remove File::tryOpen

Summary:
In hopes of keeping 'busywork' helpers out of folly, I've moved this
closer to the code that needed to do this.

Test Plan: Unit tests

Reviewed By: andrei.alexandrescu@fb.com

FB internal diff: D729194

Blame Revision: D726916
  • Loading branch information...
1 parent 9d6c66d commit a6fac16f6b71d04aaa8be6f5c0f2a1e7e70d6915 Tom Jackson committed with jdelong Mar 6, 2013
Showing with 0 additions and 23 deletions.
  1. +0 −10 folly/File.cpp
  2. +0 −8 folly/File.h
  3. +0 −5 folly/test/FileTest.cpp
View
@@ -79,16 +79,6 @@ File::~File() {
return File(fd, true);
}
-/* static */ File File::tryOpen(const char* name,
- int flags,
- mode_t mode) {
- try {
- return File(name, flags, mode);
- } catch (const std::system_error&) {
- return File();
- }
-}
-
void File::release() {
fd_ = -1;
ownsFd_ = false;
View
@@ -54,14 +54,6 @@ class File {
*/
static File temporary();
- /**
- * Attempts to open the file at the given path. Returns an 'closed` File
- * instance on failure, which will evaluate to false.
- */
- static File tryOpen(const char* name,
- int flags = O_RDONLY,
- mode_t mode = 0644);
-
/**
* Return the file descriptor, or -1 if the file was closed.
*/
View
@@ -122,8 +122,3 @@ TEST(File, Truthy) {
EXPECT_TRUE(false);
}
}
-
-TEST(File, TryOpen) {
- EXPECT_FALSE(!!File::tryOpen("does_not_exist.txt"));
- EXPECT_TRUE(!!File::tryOpen("/etc/fstab"));
-}

0 comments on commit a6fac16

Please sign in to comment.