Permalink
Browse files

Clang complains about errors in folly String-inl.h and FBString.h (P1…

…825995)

Summary: fixing clang errors (used clang 3.1)

Test Plan: doh

Reviewed By: tudorb@fb.com

FB internal diff: D622593
  • Loading branch information...
1 parent 99f7266 commit a8370f0272e565be339e275eb8852ccd602cd1fb @juchem juchem committed with jdelong Nov 6, 2012
Showing with 3 additions and 3 deletions.
  1. +1 −1 folly/FBString.h
  2. +2 −2 folly/String-inl.h
View
@@ -1269,7 +1269,7 @@ class basic_fbstring {
// std::less_equal, which is guaranteed to offer a total order
// over pointers. See discussion at http://goo.gl/Cy2ya for more
// info.
- static const std::less_equal<const value_type*> le;
+ std::less_equal<const value_type*> le;
if (UNLIKELY(le(oldData, s) && !le(oldData + oldSize, s))) {
assert(le(s + n, oldData + oldSize));
const size_type offset = s - oldData;
View
@@ -278,7 +278,7 @@ template<class Delim, class String, class OutputType>
void split(const Delim& delimiter,
const String& input,
fbvector<OutputType>& out,
- bool ignoreEmpty = false) {
+ bool ignoreEmpty) {
detail::internalSplit<OutputType>(
detail::prepareDelim(delimiter),
StringPiece(input),
@@ -451,7 +451,7 @@ void humanify(const String1& input, String2& output) {
template<class InputString, class OutputString>
bool hexlify(const InputString& input, OutputString& output,
- bool append_output=false) {
+ bool append_output) {
if (!append_output) output.clear();
static char hexValues[] = "0123456789abcdef";

0 comments on commit a8370f0

Please sign in to comment.