Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
sorted_vector_types does not work with std::inserter
Summary: The signature of insert(hint, const val& v) is wrong. It should return an iterator, not pair<iterator, bool>. This breaks std::inserter, making it impossible to use this for std::merge. I plan to create folly::merge (std::merge with stronger semantics when equal values are present in the two input ranges), so I need this fixed. Given that the documentation claims this is a "drop in replacement" for std::map, I figure we should fix this. Test Plan: reran unit tests Reviewed By: delong.j@fb.com FB internal diff: D1223396
- Loading branch information
Marc Celani
authored and
Dave Watson
committed
Mar 18, 2014
1 parent
b2d3a93
commit c363387
Showing
1 changed file
with
9 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters