Please sign in to comment.
folly (easy): Disable GCC-specific warning disabling hacks in clang
Summary: When compiling folly with clang, the compiler warns about our use of GCC-specific pragmas to silence incorrect compiler warnings: folly/Optional.h:79:33: warning: unknown warning group '-Wpragmas', ignored [-Wunknown-pragmas] folly/Optional.h:80:33: warning: unknown warning group '-Wmaybe-uninitialized', ignored [-Wunknown-pragmas] Thankfully, those incorrect compiler warnings are not emitted by clang, so we can just disable the pragmas in clang. Test Plan: Built folly in gcc and ran it through clang. Warning above is gone. Reviewed By: email@example.com FB internal diff: D733323
- Loading branch information...
Showing with 7 additions and 1 deletion.