Updated string.h #111
Updated string.h #111
Conversation
Fixed a fatal error when compiling folly for HHVM
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@raeesiqbal What is the fatal error? |
|
@JoelMarcey, we don't have the stack trace, but it was on windows. compiling same under linux/unix didn't produce that error. |
|
Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed. |
|
Thank you for your patience. We're going to close out this issue. If you're still experiencing the problem described, please reopen the issue - thanks! |
Fixed a fatal error when compiling folly for HHVM