New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize toJson() Performance #478

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@miloyip
Contributor

miloyip commented Sep 11, 2016

Removing string::reserve() which causes O(n^2) penalty.

Fixes #477

Optimize toJson() Performance
Removing string::reserve() which causes O(n^2) penalty.

@ghost ghost added the GH Review: review-needed label Sep 11, 2016

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Sep 11, 2016

Thank you for your pull request. As you may know, we require contributors to sign our Contributor License Agreement, and we don't seem to have you on file and listed as active anymore. In order for us to review and merge your code, please email cla@fb.com with your details so we can update your status.

ghost commented Sep 11, 2016

Thank you for your pull request. As you may know, we require contributors to sign our Contributor License Agreement, and we don't seem to have you on file and listed as active anymore. In order for us to review and merge your code, please email cla@fb.com with your details so we can update your status.

@ghost ghost added the CLA Signed label Sep 11, 2016

@miloyip

This comment has been minimized.

Show comment
Hide comment
@miloyip

miloyip Sep 11, 2016

Contributor

I have just signed the CLA. Thanks bot.

Contributor

miloyip commented Sep 11, 2016

I have just signed the CLA. Thanks bot.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Sep 11, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

ghost commented Sep 11, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment