Skip to content
This repository
branch: master

Fix header ordering lint failures

Summary:
Headers whose includes are not sufficient cause problems when included
from other files. An easy way to prevent this is to include the header
first in its associated cpp file. In fact, we have a lint rule for this.
However, there are places where this rule is ignored. This diff fixes
many of them.

Note that a few top-level directories were excluded.

Reviewed By: robbert@fb.com

FB internal diff: D1281032
latest commit b215baa252
Nicholas Ormrod authored April 18, 2014 sgolemon committed April 18, 2014
..
Octocat-spinner-32 build macro for cross platform x64 detection April 18, 2014
Octocat-spinner-32 detail macro for cross platform x64 detection April 18, 2014
Octocat-spinner-32 docs Update Overview.md November 05, 2013
Octocat-spinner-32 experimental Fix header ordering lint failures April 18, 2014
Octocat-spinner-32 gen (Folly/Gen) Make ranges and sequences take a stepping functor April 18, 2014
Octocat-spinner-32 io macro for cross platform x64 detection April 18, 2014
Octocat-spinner-32 m4 Add missing ax_boost_system.m4. October 14, 2013
Octocat-spinner-32 stats NULL -> nullptr March 31, 2014
Octocat-spinner-32 test macro for cross platform x64 detection April 18, 2014
Octocat-spinner-32 wangle Add missing includes for msvc April 18, 2014
Octocat-spinner-32 ApplyTuple.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 Arena-inl.h configurable alignment for Arena April 18, 2014
Octocat-spinner-32 Arena.h configurable alignment for Arena April 18, 2014
Octocat-spinner-32 AtomicBitSet.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 AtomicHashArray-inl.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 AtomicHashArray.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 AtomicHashMap-inl.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 AtomicHashMap.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 AtomicStruct.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 Baton.h macro for cross platform x64 detection April 18, 2014
Octocat-spinner-32 Benchmark.cpp uint isn't portable and makes some compilers angry, change to unsigne… April 18, 2014
Octocat-spinner-32 Benchmark.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 Bits.cpp Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 Bits.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 CPortability.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 Checksum.cpp macro for cross platform x64 detection April 18, 2014
Octocat-spinner-32 Checksum.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 Chrono.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 ConcurrentSkipList-inl.h fix ConcurrentSkipList::Recycler layout April 08, 2014
Octocat-spinner-32 ConcurrentSkipList.h configurable node allocator for ConcurrentSkipList April 08, 2014
Octocat-spinner-32 Conv.cpp Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 Conv.h Fix inclusions of double-conversion to use proper path February 28, 2014
Octocat-spinner-32 CpuId.h macro for cross platform x64 detection April 18, 2014
Octocat-spinner-32 Demangle.cpp Make Folly cpp_library targets more granular March 10, 2014
Octocat-spinner-32 Demangle.h Make Folly cpp_library targets more granular March 10, 2014
Octocat-spinner-32 DiscriminatedPtr.h macro for cross platform x64 detection April 18, 2014
Octocat-spinner-32 DynamicConverter.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 Exception.h MSVC translation of noreturn attribute April 18, 2014
Octocat-spinner-32 FBString.h fbstring likely/unlikley ifdef for stuff that doesn't support it April 18, 2014
Octocat-spinner-32 FBVector.h Bugfix in iterator emplace April 08, 2014
Octocat-spinner-32 File.cpp Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 File.h use 0666 as the default permissions for new files March 10, 2014
Octocat-spinner-32 FileUtil.cpp Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 FileUtil.h use 0666 as the default permissions for new files March 10, 2014
Octocat-spinner-32 Fingerprint.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 Foreach.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 Format-inl.h add formatChecked(), which does not crash on bad format strings February 06, 2014
Octocat-spinner-32 Format.cpp revert format()'s behavior of crashing on error February 06, 2014
Octocat-spinner-32 Format.h MSVC translation of noreturn attribute April 18, 2014
Octocat-spinner-32 FormatArg.h MSVC translation of noreturn attribute April 18, 2014
Octocat-spinner-32 GroupVarint.cpp Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 GroupVarint.h macro for cross platform x64 detection April 18, 2014
Octocat-spinner-32 Hash.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 IndexedMemPool.h include guard name cleanup for IndexedMemPool January 16, 2014
Octocat-spinner-32 IntrusiveList.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 Lazy.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 LifoSem.cpp Introduce LifoSem April 18, 2014
Octocat-spinner-32 LifoSem.h Introduce LifoSem April 18, 2014
Octocat-spinner-32 Likely.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 Logging.h make FB_LOG_EVERY_MS thread safe February 28, 2014
Octocat-spinner-32 MPMCPipeline.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 MPMCQueue.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 Makefile.am Fix make check April 08, 2014
Octocat-spinner-32 Malloc.cpp NULL -> nullptr March 31, 2014
Octocat-spinner-32 Malloc.h NULL -> nullptr March 31, 2014
Octocat-spinner-32 MapUtil.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 Memory.h configurable node allocator for ConcurrentSkipList April 08, 2014
Octocat-spinner-32 MemoryMapping.cpp Optionally specify page size in MemoryMapping ctor March 31, 2014
Octocat-spinner-32 MemoryMapping.h Optionally specify page size in MemoryMapping ctor March 31, 2014
Octocat-spinner-32 Merge.h folly::merge() - std::merge() with stronger guarantees (probably same… March 18, 2014
Octocat-spinner-32 MoveWrapper.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 Optional.h Add missing includes for msvc April 18, 2014
Octocat-spinner-32 PackedSyncPtr.h macro for cross platform x64 detection April 18, 2014
Octocat-spinner-32 Padded.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 Portability.h macro for cross platform x64 detection April 18, 2014
Octocat-spinner-32 Preprocessor.h Change paramter name to FB_STRINGIZE February 06, 2014
Octocat-spinner-32 ProducerConsumerQueue.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 RWSpinLock.h x64 detection missing an include April 18, 2014
Octocat-spinner-32 Random.cpp NULL -> nullptr March 31, 2014
Octocat-spinner-32 Random.h Replace random_device/mt19937 with folly/Random March 10, 2014
Octocat-spinner-32 Range.cpp folly: ASAN-exempt scanHaystackBlock, to avoid an FP buffer overrun February 07, 2014
Octocat-spinner-32 Range.h Range::contains(x) March 31, 2014
Octocat-spinner-32 SConstruct.double-conversion Pull from FB rev 63ce89e June 02, 2012
Octocat-spinner-32 SafeAssert.cpp Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 SafeAssert.h MSVC translation of noreturn attribute April 18, 2014
Octocat-spinner-32 ScopeGuard.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 SmallLocks.h macro for cross platform x64 detection April 18, 2014
Octocat-spinner-32 SpookyHashV1.cpp Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 SpookyHashV1.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 SpookyHashV2.cpp Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 SpookyHashV2.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 String-inl.h Support numeric types as targets for folly::split March 10, 2014
Octocat-spinner-32 String.cpp Add missing includes for msvc April 18, 2014
Octocat-spinner-32 String.h Utility that converts from prettyPrint format back to double (e.g. 10… April 03, 2014
Octocat-spinner-32 Subprocess.cpp MSVC translation of noreturn attribute April 18, 2014
Octocat-spinner-32 Subprocess.h Change child's working directory April 18, 2014
Octocat-spinner-32 Synchronized.h Fix TIMED_SYNCHRONIZED_CONST bug April 03, 2014
Octocat-spinner-32 ThreadCachedArena.cpp configurable alignment for Arena April 18, 2014
Octocat-spinner-32 ThreadCachedArena.h configurable alignment for Arena April 18, 2014
Octocat-spinner-32 ThreadCachedInt.h NULL -> nullptr March 31, 2014
Octocat-spinner-32 ThreadLocal.h abstract thread_local support April 18, 2014
Octocat-spinner-32 TimeoutQueue.cpp Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 TimeoutQueue.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 Traits.h Add missing includes for msvc April 18, 2014
Octocat-spinner-32 Unicode.cpp Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 Unicode.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 Uri-inl.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 Uri.cpp Fix folly Uri::host() return value for IPv6 address April 18, 2014
Octocat-spinner-32 Uri.h Fix folly Uri::host() return value for IPv6 address April 18, 2014
Octocat-spinner-32 Varint.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 configure.ac Move thrift/lib/cpp/async to folly. March 18, 2014
Octocat-spinner-32 dynamic-inl.h Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 dynamic.cpp Copyright 2013 -> 2014 February 06, 2014
Octocat-spinner-32 dynamic.h Make sure folly::dynamic arrays can be used with folly::gen March 18, 2014
Octocat-spinner-32 json.cpp range(), for making Range<T*> from arrays and std::vector March 18, 2014
Octocat-spinner-32 json.h Add control of floating point serialization to JSON serialization March 18, 2014
Octocat-spinner-32 small_vector.h macro for cross platform x64 detection April 18, 2014
Octocat-spinner-32 sorted_vector_types.h sorted_vector_types have move inserts March 18, 2014
Something went wrong with that request. Please try again.