Permalink
Commits on Jan 20, 2017
  1. Catch NPE from potential RC in DiskStorageCache

    Summary:
    Due to a race-condition (https://code.google.com/p/android/issues/detail?id=8886) the method `Context#getFilesDir` could return `null`. This was supposedly fixed in 4.4: https://android.googlesource.com/platform/frameworks/base/+/cc866da37db53df67e9b324815d6377bbd47d71b%5E%21/#F0
    
    As the code path is rather optional, let's just fail quietly if things go wrong there.
    
    Reviewed By: oprisnik
    
    Differential Revision: D4441647
    
    fbshipit-source-id: 1fc441a9f3f1c2080abe2a8448812cf645d6c9e3
    lambdapioneer committed with facebook-github-bot Jan 20, 2017
  2. Added cache selector for bitmap animation debug fragment

    Summary: This adds a caching strategy selector for animated images.
    
    Reviewed By: massimocarli
    
    Differential Revision: D4429082
    
    fbshipit-source-id: 24bd4deee42cff14ae60dd7cb8d4cbacc3fc5176
    oprisnik committed with facebook-github-bot Jan 20, 2017
  3. Added debugging framework for bitmap animation backends

    Summary: This adds a debugging framework to see what's cached and when frames are created / reused etc.
    
    Reviewed By: lambdapioneer
    
    Differential Revision: D4428997
    
    fbshipit-source-id: e1c1046ec166577e2f226f12adc87abe8600ade0
    oprisnik committed with facebook-github-bot Jan 20, 2017
Commits on Jan 19, 2017
  1. Bump version number to 1.0.1 in readme and docs

    Reviewed By: lambdapioneer
    
    Differential Revision: D4435551
    
    fbshipit-source-id: 497fb7d87c7532ee6b02b844db53c4e367e658ed
    oprisnik committed with facebook-github-bot Jan 19, 2017
  2. Bump version to 1.0.1

    Reviewed By: lambdapioneer
    
    Differential Revision: D4435541
    
    fbshipit-source-id: 79ae17ae20c34a0df9025674d235921cda75159d
    oprisnik committed with facebook-github-bot Jan 19, 2017
  3. Use BufferType.SPANNABLE in setText of SimpleDraweeSpanStringBuilder

    Summary:
    Explicitly uses `BufferType.SPANNABLE` to let `SimpleDraweeSpanTextView` know that it might need to resize itself. See associated issue: #1633
    
    Feel free to suggest alternative solutions; I think this is safe to do and a cursory search didn't turn up anything better, but I suspect maintainers of `DraweeSpan` might know more about spans than I do!
    Closes #1634
    
    Differential Revision: D4435370
    
    Pulled By: oprisnik
    
    fbshipit-source-id: 09dcbc9a3360771a726cf283d9ff20da8b1d94f1
    angarron committed with facebook-github-bot Jan 19, 2017
  4. Animations v2: Added frame cache listener

    Summary: Listening to frame caching events can be useful for debugging.
    
    Reviewed By: lambdapioneer
    
    Differential Revision: D4428944
    
    fbshipit-source-id: ca7e61b059708385490c516f08bc2d67d4546ba8
    oprisnik committed with facebook-github-bot Jan 19, 2017
Commits on Jan 18, 2017
  1. Allow setting a custom PipelineDraweeControllerFactory in DraweeConfig

    Summary: Added a method to DraweeConfig.Builder for injecting a custom PipelineDraweeControllerFactory.
    
    Reviewed By: lambdapioneer
    
    Differential Revision: D4422946
    
    fbshipit-source-id: 993fd2c8d6c2410c9726bc1724c4ae65f17220e3
    erikandre committed with facebook-github-bot Jan 18, 2017
  2. Fix LocalFileFetchToEncodedMemoryPrefetchSequence

    Summary: After adding prefetching for local files, the generated sequences would include the `NetworkFetchProducer` instead of the `LocalFileFetchProducer`. This diff makes the sequence use the correct one.
    
    Reviewed By: oprisnik
    
    Differential Revision: D4423001
    
    fbshipit-source-id: 93cf79b5bb640811f3049242e05bbbe45d4f0905
    lambdapioneer committed with facebook-github-bot Jan 18, 2017
  3. LibWebp upgraded to 0.5.2 on gradle

    Summary: Libwebp upgraded to 0.5.2
    
    Reviewed By: lambdapioneer
    
    Differential Revision: D4422744
    
    fbshipit-source-id: 8e4272ec392e74cdc2247bfd8dc68914c8388cb5
    massimocarli committed with facebook-github-bot Jan 18, 2017
Commits on Jan 17, 2017
  1. Animations v2: Added simple bitmap example

    Summary: Added a simple bitmap backend example that renders a color and the frame number.
    
    Reviewed By: kirwan
    
    Differential Revision: D4422950
    
    fbshipit-source-id: b5a933294473d291785e0d56ea7215c4fac133cc
    oprisnik committed with facebook-github-bot Jan 17, 2017
  2. Fix showcase proguard setup

    Summary: This fixes missing proguard definitions for the SVG library used in one of the samples.
    
    Reviewed By: lambdapioneer, massimocarli
    
    Differential Revision: D4422869
    
    fbshipit-source-id: 8a9f3cb05129dd3589eb74a8597230cb0864be73
    oprisnik committed with facebook-github-bot Jan 17, 2017
  3. Ignore lint warning for showcase sample

    Summary: Release builds with `./gradlew  :samples:showcase:build` are failing due to the lint error.
    
    Reviewed By: foghina
    
    Differential Revision: D4422805
    
    fbshipit-source-id: be7e3a4c1d21ae285706f52e59a9d627c0597db2
    oprisnik committed with facebook-github-bot Jan 17, 2017
  4. Animations v2: Added backend selector

    Summary: This adds a backend selector to the animations2 sample app.
    
    Reviewed By: lambdapioneer
    
    Differential Revision: D4421316
    
    fbshipit-source-id: 3b9b4f49c8893bd670010af95a16d51d94243a03
    oprisnik committed with facebook-github-bot Jan 17, 2017
Commits on Jan 14, 2017
  1. Animations v2: Added local drawable backend

    Summary: This adds a simple backend that cycles through local drawables.
    
    Reviewed By: massimocarli
    
    Differential Revision: D4414772
    
    fbshipit-source-id: d1aebfbcd3f5cb2b487fa588373fecb2a4f7f579
    oprisnik committed with facebook-github-bot Jan 14, 2017
Commits on Jan 13, 2017
  1. download giflib from launchpad.net

    Summary: Sourceforge is super unreliable and our CircleCI build is failing because it can't download giflib from there. Switch to downloading from launchpad.net (bonus: HTTPS).
    
    Reviewed By: kirwan
    
    Differential Revision: D4414782
    
    fbshipit-source-id: 42dd0daf4b4588963fbc3edc0622f5af90406669
    foghina committed with facebook-github-bot Jan 13, 2017
  2. RotationAngle added to Log

    Summary: Log about rotation added
    
    Reviewed By: kirwan
    
    Differential Revision: D4409498
    
    fbshipit-source-id: 2168648698a014b52217d03921be2cc403aba2d7
    massimocarli committed with facebook-github-bot Jan 13, 2017
Commits on Jan 12, 2017
  1. Added animations v2 media control example

    Summary: This adds a simple media control example for animations v2.
    
    Reviewed By: massimocarli
    
    Differential Revision: D4404478
    
    fbshipit-source-id: d16d4a39d76fbd3035addb4ab887e4b4202b4b85
    oprisnik committed with facebook-github-bot Jan 12, 2017
  2. Animations v2: extracted color sample backend

    Summary: The color sample is now in a separate class so that it's easier to re-use.
    
    Reviewed By: massimocarli
    
    Differential Revision: D4409508
    
    fbshipit-source-id: 0d949c287e678e1f84e93aca335c4b54ce15a69d
    oprisnik committed with facebook-github-bot Jan 12, 2017
  3. AnimatedDrawable2: Fixed frame seeking

    Summary: Frame seeking did not work properly since it stopped the animation and reset the current animation state.
    
    Reviewed By: massimocarli
    
    Differential Revision: D4404243
    
    fbshipit-source-id: 5eff7f3f2827edb7080f14464a44b9efc48a29d0
    oprisnik committed with facebook-github-bot Jan 12, 2017
  4. Immutable objects instance replication removed

    Summary: Immutable classes can be instantiated once.
    
    Reviewed By: oprisnik
    
    Differential Revision: D4409846
    
    fbshipit-source-id: abe526f9b99ca8ede5eba53d8b2c1fbff5722dad
    massimocarli committed with facebook-github-bot Jan 12, 2017
  5. add IssueCommands.txt for github bot, stack-overflow command

    Reviewed By: mkonicek
    
    Differential Revision: D4403732
    
    fbshipit-source-id: 09a9f7c6eaaebdaa427614285f68e96cfc4d2b7d
    foghina committed with facebook-github-bot Jan 12, 2017
Commits on Jan 11, 2017
  1. Make ProgressBarDrawable implement CloneableDrawable

    Reviewed By: massimocarli
    
    Differential Revision: D4403804
    
    fbshipit-source-id: e673b7c9ee502bae5e598293c3c2d11f8aa16e57
    lambdapioneer committed with facebook-github-bot Jan 11, 2017
  2. Ratio conversion fixed

    Summary: Fixed the conversion between different ratio values
    
    Reviewed By: kirwan
    
    Differential Revision: D4398135
    
    fbshipit-source-id: 3cc4ebe5682b088025e8793a597e2048cd7a72a2
    massimocarli committed with facebook-github-bot Jan 11, 2017
Commits on Jan 10, 2017
  1. Provide canonical way to create ImageRequest for local files

    Summary:
    This change adds a canonical method `ImageRequest#fromFile` in order to allow developers not having to care about the correct way to create URIs for local files.
    
    Closes #1596
    
    Reviewed By: oprisnik
    
    Differential Revision: D4386923
    
    fbshipit-source-id: e2edc8f31b7dd2ea7698a5b1bba9fcd47da67923
    lambdapioneer committed with facebook-github-bot Jan 10, 2017
Commits on Jan 9, 2017
  1. Fix WebpBitmapFactoryImpl.createBitmap() being called with wrong class

    Summary:
    When JNI debugging is enabled, ART is very pedantic about what class you are passing when invoking static method. In this case, this is causing a crash:
    
    runtime.cc:476] JNI DETECTED ERROR IN APPLICATION: can't call static android.graphics.Bitmap com.facebook.webpsupport.WebpBitmapFactoryImpl.createBitmap(int, int, android.graphics.BitmapFactory$Options) with class java.lang.Class<android.graphics.Bitmap>
    runtime.cc:476]     in call to CallStaticObjectMethodV
    runtime.cc:476]     from android.graphics.Bitmap com.facebook.webpsupport.WebpBitmapFactoryImpl.nativeDecodeByteArray(byte[], int, int, android.graphics.BitmapFactory$Options, float, byte[])
    Closes #1607
    
    Reviewed By: massimocarli, oprisnik
    
    Differential Revision: D4386800
    
    Pulled By: foghina
    
    fbshipit-source-id: 876e0fb944ebb42f5ace242b67f119c57ca2464a
    korDen committed with facebook-github-bot Jan 9, 2017
  2. Moved custom decoder color XML example to the Showcase app and delete…

    …d decoder sample app
    
    Summary:
    The decoder sample app only had a single color XML sample decoders since we added the others to the Showcase sample.
    I moved the color XML sample to the Showcase app and adapted it accordingly and also removed the old sample app since it's no longer needed.
    
    Reviewed By: massimocarli
    
    Differential Revision: D4375212
    
    fbshipit-source-id: cefe4b09c2377f165a9f89799ca93f32b0083671
    oprisnik committed with facebook-github-bot Jan 9, 2017
  3. Don't detach a controller if it has been set elsewhere

    Reviewed By: kirwan
    
    Differential Revision: D4381209
    
    fbshipit-source-id: dcdf693ffa9b2c775ad0981e3fb3b35262a3a5ed
    IanChilds committed with facebook-github-bot Jan 9, 2017
  4. Add GigTown in the apps using Fresco

    Summary: Closes #1603
    
    Differential Revision: D4392125
    
    Pulled By: kirwan
    
    fbshipit-source-id: bca407b4a9802281bc60ac5bbb63ce63bddd0a53
    sachins committed with facebook-github-bot Jan 9, 2017
Commits on Jan 8, 2017
  1. Use feed plugin

    Summary:
    I removed the manual feed in 47be753
    but forgot the plugin to replace it
    Closes #1616
    
    Differential Revision: D4391246
    
    Pulled By: JoelMarcey
    
    fbshipit-source-id: 1f460f5feb86a33f463e13cb1ee691eaac6fff6f
    JoelMarcey committed with facebook-github-bot Jan 8, 2017
Commits on Jan 6, 2017
  1. Jekyll Updates

    Summary:
    - Add Gemfile to allow easy running of site locally
    - Use new seo plugin for og info
    - Use feed plugin for the XML feed
    - Use relative URLs for local-to-site links in nav bar (makes it easier for local testing too)
    
    See facebook/nuclide#952 where some of this was provided for Nuclide by a GitHub team member
    
    Tested by running site locally.
    Closes #1614
    
    Differential Revision: D4386846
    
    Pulled By: lambdapioneer
    
    fbshipit-source-id: b4cbc9fa90ce0ab858347bbd0a3424e51c8a5598
    JoelMarcey committed with facebook-github-bot Jan 6, 2017
Commits on Jan 4, 2017
  1. Remove explicit, although empty, baseurl

    Summary:
    We are running into problem with bot-commits again like we did with Nuclide. bot-commits are causing problems with GitHub pages, appending baseurls when there should not be any.
    Let's remove it from the config and see if that fixes the issue for now.
    Closes #1612
    
    Differential Revision: D4382175
    
    Pulled By: JoelMarcey
    
    fbshipit-source-id: 2e77225d7dbd2c8c41712cf6c9753e092356af5f
    JoelMarcey committed with facebook-github-bot Jan 4, 2017
  2. Small edit to docs - mainly for testing

    Summary:
    While the change here is good, this is mainly to test GitHub Pages.
    We want to move the docs to master and serve from there, but it is
    possible the docs ran into the bot commit issue that hampered nuclide
    in the past. This is testing this.
    Closes #1611
    
    Differential Revision: D4381947
    
    Pulled By: lambdapioneer
    
    fbshipit-source-id: 1439a45cc2c122a25c7c7a8ea321094213f4126c
    JoelMarcey committed with facebook-github-bot Jan 4, 2017
  3. Revert D3334641: fix loading local file fail with special character

    Differential Revision: D3334641
    
    fbshipit-source-id: 5fd4b4f5531d8e933e9ceb9891d123aeb7edc395
    lambdapioneer committed with facebook-github-bot Jan 4, 2017
Commits on Jan 3, 2017
  1. Showcase: Added Drawee rotation example

    Summary: This adds a sample fragment that shows different `RotationOptions` and their effect on a `SimpleDraweeView`.
    
    Reviewed By: lambdapioneer
    
    Differential Revision: D4372741
    
    fbshipit-source-id: 405b713e3c8ae865bae61d4f12b5fc0436e7b13d
    oprisnik committed with facebook-github-bot Jan 3, 2017