Set bitmap to canvas before translating canvas #2118
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation (required)
On Android Oreo and building with target SDK 26 or above,
PlatformBitmapFactory#createScaledBitmap
doesn't work correctly.Because,
Canvas#setBitmap
behavior was changed on SDK 26. Calling setBitmap causes reset translation of canvas.So, we should call setBitmap before translating canvas.
This behavior changes are mentioned at javadoc of
Canvas#setBitmap
ref: https://github.com/aosp-mirror/platform_frameworks_base/blob/oreo-release/graphics/java/android/graphics/Canvas.java#L160-L172
Test Plan (required)
Tested on Sample app on target SDK 26 and Oreo device