Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Spec: Formal Subscriptions Definition #305
referenced this pull request
May 13, 2017
This is looking awesome. More fine-grained feedback this time
Getting excited! Most feedback here is within the algorithms
I took another pass and made changes per your suggestions. Reading everything top-to-bottom, it feels a lot more dense/verbose. We also have some duplication, for example with ExecuteSubscriptionEvent. Do you feel this restructuring buys us consistency/clarity?
There are some other sections which need some updates:
Yes, I think that it helps to illustrate the seam between creating a subscription and executing each event, which will help those building this across two services.