Please sign in to comment.
Hack rage - capture pstacks and old logs
Summary: When the user hits the bug button in their editor, it sends a "telemetry/rage" LSP request to clientLsp.ml. Currently this gathers up the .log and .monitor_log file. This diff brings two changes: * It now gathers up the .log.old and monitor_log.old files as well (so we can see why the previous instance crashed!) * It now gathers PSTACKS for the server process and the monitor process, so if they've hanged, then we can see why. Discussion: I had first considered obtaining all logs from the /tmp/hh_server/logs and /monitor_logs directories. But this would have combined logs from ALL different instances of hh_server on this box, rather than just the hh_server for this particular project root. I preferred to keep it local. I had first considered doing "ps -aux | grep hh_server" to find all processes. But once again that would have obtained pstacks from ALL different instances of hh_server on this box. And the PidLogs.ml file does after all contain the logs I want. I had first considered getting PSTACKS for *all* PIDs mentioned by PidLogs.ml, including all the workers. But there were ~30 of them, and they were all doing boring stuff, and they crowded out the logs, so it didn't seem worth it. Reviewed By: arxanas Differential Revision: D6882227 fbshipit-source-id: f8e58afd3c61469bede3ab052050e6de73663d78
- Loading branch information...