Please sign in to comment.
Fix more MacOS crashes due to non-portable local labels (#8278)
Summary: Isolated repro of the problem: https://gist.github.com/fredemmott/e3b7f6f1b41be02e5980416677dd05a6 There's a few issues muddled together here: - the `.l%=` labels were never actually local labels, but were presumably meant to be (`.L`) - labels are case-sensitive, so fixing that made it so that we hit duplicates with other `.L%=` labels in some files, depending on how aggressive the compiler is at inlining (this is an issue with gcc5, but not apple clang) - the crashes on MacOS due to non-local labels weren't an issue on GCC5/Linux - despite them also being non-local labels there - because GCC5/Linux isn't inserting the incorrect `noexcept` frame metadata fixes #8276 Pull Request resolved: #8278 Reviewed By: alexeyt Differential Revision: D9226853 Pulled By: fredemmott
- Loading branch information...
Showing with 16 additions and 13 deletions.