Permalink
Browse files

Make our gdb-utils work better on Arm64

Summary:
Apparently gdb.unwinder isn't a thing, so fail gracefully for modules
that use it.

Also, gdb.Type doesn't always have a name property (pretty sure I've
seen failures like this on x64 too, just not often enough to make me
investigate), so make nameof fail gracefully in that case.

Reviewed By: mxw

Differential Revision: D7098561

fbshipit-source-id: edf6a5065bb1ddd38fbfb89e6a34160d897aa1b9
  • Loading branch information...
markw65 authored and hhvm-bot committed Feb 28, 2018
1 parent a8d2ab2 commit 20bcc3b1b0a1d4c63418c9a27bb5685d74c93bf3
Showing with 9 additions and 3 deletions.
  1. +5 −2 hphp/tools/gdb/hhvm.py
  2. +4 −1 hphp/tools/gdb/nameof.py
@@ -21,8 +21,11 @@
import pretty
import repo
import sizeof
import stack
try:
import unwind
import stack
except:
pass
import unit
import unwind
import util
import ringbuffer
@@ -13,7 +13,10 @@
def nameof(val):
val = deref(val)
t = val.type.name
try:
t = val.type.name
except:
return None
sd = None

0 comments on commit 20bcc3b

Please sign in to comment.