Permalink
Browse files

didSave should be a no-op

Summary:
`textDocument/didSave` has been around since v2 of LSP. Therefore it is not capability-based, and all servers are required to implement it. Microsoft/language-server-protocol#193

We implement it with a no-op.

Reviewed By: arxanas

Differential Revision: D5342464

fbshipit-source-id: 5e7e34ef68b77146d5c01e9f83fc3a5040e9f5b9
  • Loading branch information...
ljw1004 authored and hhvm-bot committed Jun 30, 2017
1 parent 4137ac4 commit 37b8a7292c64a91f5155dc5f2bfaa47a5fa25c40
Showing with 4 additions and 0 deletions.
  1. +4 −0 hphp/hack/src/client/clientLsp.ml
@@ -1408,6 +1408,10 @@ let handle_event
| Main_loop menv, Client_message c when c.method_ = "textDocument/didChange" ->
parse_didChange c.params |> do_didChange menv.conn
(* textDocument/didSave notification *)
| Main_loop _menv, Client_message c when c.method_ = "textDocument/didSave" ->
()
(* shutdown request *)
| Main_loop menv, Client_message c when c.method_ = "shutdown" ->
do_shutdown menv.conn |> print_shutdown |> respond stdout c;

0 comments on commit 37b8a72

Please sign in to comment.