Skip to content
Browse files
Remove dead TODO for ContiguousHeap
Reviewed By: binliu19

Differential Revision: D6896345

fbshipit-source-id: 001f1e87dbe358d7c1829601a7791aaf282f2291
  • Loading branch information
edwinsmith authored and hhvm-bot committed Feb 4, 2018
1 parent 2b3ec8c commit 4967a313d60535b5af518983a2985596b42a892d
Showing with 0 additions and 4 deletions.
  1. +0 −4 hphp/runtime/base/heap-collect.cpp
@@ -148,10 +148,6 @@ struct Collector {
APCGCManager* const apcgc_;

// TODO(T20460162): The contiguous heap has a bitmap of which chunks of memory
// are allocated/free. And it can efficiently find the start of an allocated
// object using bit operations. So there is an opportunity to speed this up by
// directly accessing the bitmap instead of using PtrMap.
HeapObject* Collector::find(const void* ptr) {
if (uintptr_t(ptr) - uintptr_t(slabs_range_.ptr) < slabs_range_.size &&
slab_map_.test(slab_index(ptr))) {

0 comments on commit 4967a31

Please sign in to comment.