Permalink
Browse files

Make debugger work with requests spawned with xbox_task_start

Summary:
The debugger was not attaching to these requests, meaning that while they can hit hphp_debug_break breakpoints, they can't step or hit regular breakpoints.

Fixing github issue #8218 (comment)

Reviewed By: alexmalyshev

Differential Revision: D8730411

fbshipit-source-id: c35f922aab35e2ed04263649740110b3c2931877
  • Loading branch information...
ebluestein authored and fredemmott committed Jul 9, 2018
1 parent ced95a0 commit 572d75b337e9c9b2c75b5de72689826110f573a3
Showing with 0 additions and 5 deletions.
  1. +0 −5 hphp/runtime/server/rpc-request-handler.cpp
@@ -34,7 +34,6 @@
#include "hphp/runtime/server/satellite-server.h"
#include "hphp/runtime/server/server-stats.h"
#include "hphp/runtime/server/source-root-info.h"
#include "hphp/runtime/vm/debugger-hook.h"
#include "hphp/runtime/vm/vm-regs.h"
#include "hphp/runtime/vm/treadmill.h"
@@ -310,10 +309,6 @@ bool RPCRequestHandler::executePHPFunction(Transport *transport,
}
int output = transport->getIntParam("output", requestMethod);
// We don't debug RPC requests, so we need to detach the installed debugger
// hook (only if there is one).
DEBUGGER_ATTACHED_ONLY(DebuggerHook::detach());
int code;
if (!error) {
Variant funcRet;

0 comments on commit 572d75b

Please sign in to comment.