Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Fix escaping string literals in various cases
Summary: This fixes two bugs: Interpolated heredocs need to be escaped using heredoc escaping rules, not doublequotedstring rules, but interpolated heredocs are parsed as a SyntaxList, so there's no way to tell the location without looking at the token kind in the lowerer. Second, \X42 = \x42 in PHP, so both need to escape to the letter A. This adds the "X" case. Reviewed By: vladima Differential Revision: D6951735 fbshipit-source-id: fbae7c3006fdc0b832f444625d972a46ed9880f6
- Loading branch information
Showing
with
13 additions
and 11 deletions.
@@ -1,6 +1,4 @@ | ||
spec/tests/constants/core_predefined_constants2.php | ||
spec/tests/lexical_structure/tokens/heredoc_string_literals.php | ||
spec/tests/lexical_structure/tokens/string_literals.php | ||
spec/tests/statements/declare/declare.php | ||
spec/tests/statements/selection/if.php | ||
spec/tests/statements/selection/switch.php | ||
spec/tests/statements/selection/switch.php |