Permalink
Browse files

Remove xinit assert to unblock trunk breaks

Summary: Temporary fix for T34583281 because assertion on `xinit` fails in certain cases.

Reviewed By: markw65

Differential Revision: D10119375

fbshipit-source-id: bbac990de9a3cce6101c40f170bde4e2951e6fcb
  • Loading branch information...
leikahing authored and hhvm-bot committed Sep 29, 2018
1 parent c0ad1e8 commit 79152ba1e1d7fe88b3a244a993a649936540d694
Showing with 3 additions and 1 deletion.
  1. +3 −1 hphp/hhbbc/index.cpp
@@ -2162,7 +2162,9 @@ bool merge_xinits(Attr attr,
}
}
assertx(xinit);
// TODO reimplement assertion check after fixing T34583281
//assertx(xinit);
if (!xinit) return true;
if (empty) {
ITRACE(5, "merge_xinits: adding {}::{} to method table\n",
xinit->cls->name, xinit->name);

0 comments on commit 79152ba

Please sign in to comment.