Skip to content

/ hhvm

Permalink
Browse files

Kill Compiler::Error and various Expression:: attributes 

Summary:
Nobody looks at the Compiler::Error results; and most of the useful
ones are no longer even generated.

Reviewed By: ricklavoie, alexeyt

Differential Revision: D6874242

fbshipit-source-id: 3fd90119bae10582c08d85dcc9bb350b4ff9169a
  • Loading branch information
@hhvm-bot
Mark Williams authored and hhvm-bot committed Feb 2, 2018
1 parent 107e1d3 commit 9767a8793b80f0e7422343fe24f84493cf7c15b3
Unified Split
Showing with 6 additions and 567 deletions.
  1. +0 −1 .gitignore
  2. +0 −1 hphp/.gitignore
  3. +0 −15 hphp/compiler/CMakeLists.txt
  4. +0 −1 hphp/compiler/analysis/analysis_result.cpp
  5. +0 −1 hphp/compiler/analysis/analysis_result.h
  6. +0 −3 hphp/compiler/analysis/class_scope.cpp
  7. +0 −208 hphp/compiler/analysis/code_error.cpp
  8. +0 −73 hphp/compiler/analysis/code_error.h
  9. +0 −3 hphp/compiler/analysis/emitter.cpp
  10. +0 −1 hphp/compiler/analysis/file_scope.cpp
  11. +0 −1 hphp/compiler/analysis/file_scope.h
  12. +0 −2 hphp/compiler/analysis/function_scope.cpp
  13. +0 −7 hphp/compiler/compiler.cpp
  14. +1 −32 hphp/compiler/construct.cpp
  15. +1 −4 hphp/compiler/construct.h
  16. +0 −5 hphp/compiler/expression/array_element_expression.cpp
  17. +0 −3 hphp/compiler/expression/assignment_expression.cpp
  18. +0 −2 hphp/compiler/expression/binary_op_expression.cpp
  19. +0 −1 hphp/compiler/expression/class_constant_expression.cpp
  20. +0 −1 hphp/compiler/expression/constant_expression.cpp
  21. +0 −1 hphp/compiler/expression/dynamic_function_call.cpp
  22. +0 −1 hphp/compiler/expression/dynamic_variable.cpp
  23. +0 −1 hphp/compiler/expression/encaps_list_expression.cpp
  24. +1 −22 hphp/compiler/expression/expression.cpp
  25. +0 −11 hphp/compiler/expression/expression.h
  26. +0 −2 hphp/compiler/expression/function_call.cpp
  27. +0 −5 hphp/compiler/expression/include_expression.cpp
  28. +0 −1 hphp/compiler/expression/list_assignment.cpp
  29. +0 −1 hphp/compiler/expression/new_object_expression.cpp
  30. +0 −1 hphp/compiler/expression/null_coalesce_expression.cpp
  31. +0 −1 hphp/compiler/expression/object_method_expression.cpp
  32. +0 −5 hphp/compiler/expression/object_property_expression.cpp
  33. +1 −3 hphp/compiler/expression/parameter_expression.cpp
  34. +0 −1 hphp/compiler/expression/qop_expression.cpp
  35. +0 −1 hphp/compiler/expression/scalar_expression.cpp
  36. +0 −1 hphp/compiler/expression/simple_function_call.cpp
  37. +0 −1 hphp/compiler/expression/static_member_expression.cpp
  38. +0 −4 hphp/compiler/expression/unary_op_expression.cpp
  39. +0 −35 hphp/compiler/parser/parser.cpp
  40. +0 −5 hphp/compiler/parser/parser.h
  41. +0 −1 hphp/compiler/statement/catch_statement.cpp
  42. +0 −1 hphp/compiler/statement/class_constant.cpp
  43. +0 −3 hphp/compiler/statement/class_require_statement.cpp
  44. +0 −3 hphp/compiler/statement/class_statement.cpp
  45. +0 −4 hphp/compiler/statement/class_variable.cpp
  46. +0 −1 hphp/compiler/statement/foreach_statement.cpp
  47. +0 −5 hphp/compiler/statement/function_statement.cpp
  48. +0 −1 hphp/compiler/statement/global_statement.cpp
  49. +1 −19 hphp/compiler/statement/goto_statement.cpp
  50. +0 −2 hphp/compiler/statement/goto_statement.h
  51. +0 −1 hphp/compiler/statement/interface_statement.cpp
  52. +1 −2 hphp/compiler/statement/label_statement.cpp
  53. +0 −2 hphp/compiler/statement/label_statement.h
  54. +0 −28 hphp/compiler/statement/method_statement.cpp
  55. +0 −2 hphp/compiler/statement/return_statement.cpp
  56. +0 −1 hphp/compiler/statement/statement_list.cpp
  57. +0 −1 hphp/compiler/statement/switch_statement.cpp
  58. +0 −1 hphp/compiler/statement/unset_statement.cpp
  59. +0 −1 hphp/compiler/statement/use_trait_statement.cpp
  60. +0 −10 hphp/parser/parser.cpp
  61. +0 −3 hphp/parser/parser.h
  62. +0 −4 hphp/runtime/ext/factparse/parser.cpp
  63. +0 −3 hphp/runtime/ext/factparse/parser.h
1 .gitignore
View file
@@ -24,7 +24,6 @@ hphp.log
/hphp/test/vm/perf/*.diff
/hphp/test/vm/perf/*.perf
/hphp/runtime/ext_hhvm/ext_noinline.cpp
/hphp/compiler/analysis/code_error.inc
/hphp/runtime/ext/*/CMakeLists.txt
/hphp/runtime/ext/*/*.so

1 hphp/.gitignore
View file
@@ -11,7 +11,6 @@ CMakeFiles
/CMakeCache.txt
cmake_install.cmake
Makefile
/compiler/analysis/code_error.inc
/runtime/ir-opcode-generated.h
/util/generated-compiler-id.txt
/util/generated-repo-schema-id.txt
15 hphp/compiler/CMakeLists.txt
View file
@@ -13,21 +13,6 @@ auto_sources(files "*.h" "{$SOURCE_SUBDIRS}")
list(APPEND HEADER_SOURCES ${files})
HHVM_PUBLIC_HEADERS(compiler ${files})


set(ERROR_INC "analysis/core_code_error.inc")

set(ERROR_INC_FILE "${CMAKE_CURRENT_SOURCE_DIR}/analysis/code_error.inc")

file(REMOVE "${ERROR_INC_FILE}")

file(WRITE "${ERROR_INC_FILE}" "/* This file is auto generated */")

foreach (error_file ${ERROR_INC})
file(READ ${error_file} file_contents)

file(APPEND "${ERROR_INC_FILE}" "${file_contents}")
endforeach (error_file ${ERROR_INC})

include_directories("${CMAKE_CURRENT_SOURCE_DIR}/../")

set(CMAKE_CURRENT_BINARY_DIR "${CMAKE_SOURCE_DIR}/bin")
1 hphp/compiler/analysis/analysis_result.cpp
View file
@@ -28,7 +28,6 @@
#include <vector>

#include "hphp/compiler/analysis/class_scope.h"
#include "hphp/compiler/analysis/code_error.h"
#include "hphp/compiler/analysis/exceptions.h"
#include "hphp/compiler/analysis/file_scope.h"
#include "hphp/compiler/analysis/function_scope.h"
1 hphp/compiler/analysis/analysis_result.h
View file
@@ -18,7 +18,6 @@
#define incl_HPHP_ANALYSIS_RESULT_H_

#include "hphp/compiler/code_generator.h"
#include "hphp/compiler/analysis/code_error.h"
#include "hphp/compiler/option.h"
#include "hphp/compiler/analysis/block_scope.h"
#include "hphp/compiler/analysis/function_container.h"
3 hphp/compiler/analysis/class_scope.cpp
View file
@@ -17,7 +17,6 @@
#include "hphp/compiler/analysis/class_scope.h"

#include "hphp/compiler/analysis/analysis_result.h"
#include "hphp/compiler/analysis/code_error.h"
#include "hphp/compiler/analysis/file_scope.h"
#include "hphp/compiler/analysis/function_scope.h"
#include "hphp/compiler/construct.h"
@@ -73,7 +72,6 @@ ClassScope::ClassScope(FileScopeRawPtr fs,
for (unsigned i = 0; i < attrs.size(); ++i) {
if (m_userAttributes.find(attrs[i]->getName()) != m_userAttributes.end()) {
attrs[i]->parseTimeFatal(fs,
Compiler::DeclaredAttributeTwice,
"Redeclared attribute %s",
attrs[i]->getName().c_str());
}
@@ -258,7 +256,6 @@ bool ClassScope::addFunction(AnalysisResultConstRawPtr /*ar*/,
FunctionScopePtr &func = m_functions[funcScope->getScopeName()];
if (func) {
func->getStmt()->parseTimeFatal(fileScope,
Compiler::DeclaredMethodTwice,
"Redeclared method %s::%s",
getScopeName().c_str(),
func->getScopeName().c_str());
208 hphp/compiler/analysis/code_error.cpp
View file

This file was deleted.

73 hphp/compiler/analysis/code_error.h
View file

This file was deleted.

3 hphp/compiler/analysis/emitter.cpp
View file
@@ -40,7 +40,6 @@

#include "hphp/compiler/builtin_symbols.h"
#include "hphp/compiler/analysis/class_scope.h"
#include "hphp/compiler/analysis/code_error.h"
#include "hphp/compiler/analysis/file_scope.h"
#include "hphp/compiler/analysis/function_scope.h"
#include "hphp/compiler/expression/array_element_expression.h"
@@ -12444,8 +12443,6 @@ void emitAllHHBC(AnalysisResultPtr&& ar) {
TypeConstraint tc;
}

Compiler::ClearErrors();

JobQueueDispatcher<EmitterWorker>
dispatcher(threadCount, 0, false, ar.get());

1 hphp/compiler/analysis/file_scope.cpp
View file
@@ -21,7 +21,6 @@

#include "hphp/compiler/analysis/analysis_result.h"
#include "hphp/compiler/analysis/class_scope.h"
#include "hphp/compiler/analysis/code_error.h"
#include "hphp/compiler/analysis/function_scope.h"

#include "hphp/compiler/expression/closure_expression.h"
1 hphp/compiler/analysis/file_scope.h
View file
@@ -23,7 +23,6 @@
#include <vector>

#include "hphp/compiler/analysis/block_scope.h"
#include "hphp/compiler/analysis/code_error.h"
#include "hphp/compiler/analysis/function_container.h"
#include "hphp/compiler/hphp.h"

0 comments on commit 9767a87

Please sign in to comment.