Please sign in to comment.
[HPHP Tainting] Cleanup
Summary: This is just a bit of cleanup, but deserves maybe a bit of explanation: - I removed the set/clear mask NO_TRACE system. Even after a thorough IDL audit, these don't seem to have any real use. We may someday want the ability to delay tracing in PHPland (which is somewhat like the set_mask functionality), but implementing this at the TaintObserver level would require some kind of mask inheritance, which is undesireable. Similarly, the TaintTracerSwitchGuard has functionality like clear_mask. - I also removed the helper macro for TAINT_FLAG_HTML_CLEAN because it is rather taint-like and looks more consistent without the wrapper. - Removed comments that are at this point covered in the README. - Also fixed a trace message. Test Plan: ran some requests in hphpi Reviewers: srenfro, amenghra, mwilliams Reviewed By: amenghra CC: ps, mwilliams, amenghra Differential Revision: 312566
- Loading branch information...
Showing with 14 additions and 55 deletions.