Rename the argument --enable-global-access-check-files

Summary: Rename the argument from "`--enable-global-access-check`" to "`--enable-global-access-check-files`" (which turns on the checker for the files with the given prefix), such that it can be easily distinguish from another argument "`--enable-global-access-check-functions`" (which turns on the checker for the functions in the given json file) by the name.

Reviewed By: jamesjwu, yuxuanchen1997

Differential Revision: D40035427

fbshipit-source-id: e8b262f069ef0e24869bd709cb4cb88f2a531317

Author: Chaoqiang Deng

hphp/hack/src/hackrs/compare_folded_decls_file.ml

@@ -242,7 +242,7 @@ let () =
       (* The following options do not affect the direct decl parser and can be ignored
          (they are used by hh_single_type_check, and we run hh_single_decl over all of
          the typecheck test cases). *)
-      ignored_arg "--enable-global-access-check";
+      ignored_arg "--enable-global-access-check-files";
       ignored_arg "--enable-global-access-check-functions";
       ignored_flag "--abstract-static-props";
       ignored_arg "--allowed-decl-fixme-codes";

hphp/hack/src/hh_oxidize/convert_toplevel_phrase.ml

@@ -75,8 +75,8 @@ let enum_modules =
     ("error_codes", "NastCheck");
     ("error_codes", "Typing");
     ("error_codes", "Init");
-    (* An optional error set that runs only for arg --enable-global-access-check
-       or --enable-global-access-check-function. *)
+    (* An optional error set that runs only for arg --enable-global-access-check-files
+       or --enable-global-access-check-functions. *)
     ("error_codes", "GlobalWriteCheck");
   ]
 

hphp/hack/src/hh_single_decl.ml

@@ -241,7 +241,7 @@ let () =
       (* The following options do not affect the direct decl parser and can be ignored
          (they are used by hh_single_type_check, and we run hh_single_decl over all of
          the typecheck test cases). *)
-      ignored_arg "--enable-global-access-check";
+      ignored_arg "--enable-global-access-check-files";
       ignored_arg "--enable-global-access-check-functions";
       ignored_flag "--abstract-static-props";
       ignored_arg "--allowed-decl-fixme-codes";

hphp/hack/src/hh_single_type_check.ml

@@ -328,7 +328,7 @@ let parse_options () =
     ref (TypecheckerOptions.profile_top_level_definitions GlobalOptions.default)
   in
   let memtrace = ref None in
-  let enable_global_access_check = ref [] in
+  let enable_global_access_check_files = ref [] in
   let enable_global_access_check_functions = ref SSet.empty in
   let refactor_mode = ref "" in
   let refactor_analysis_mode = ref "" in
@@ -814,14 +814,15 @@ let parse_options () =
         " Sets the amount of fuel that the type printer can use to display an individual type. Default: "
         ^ string_of_int
             (TypecheckerOptions.type_printer_fuel GlobalOptions.default) );
-      ( "--enable-global-access-check",
+      ( "--enable-global-access-check-files",
         Arg.String
-          (fun s -> enable_global_access_check := String_utils.split ',' s),
-        " Run global write checker on any file whose path is prefixed by the argument (use \"\\\" for hh_single_type_check)"
+          (fun s ->
+            enable_global_access_check_files := String_utils.split ',' s),
+        " Run global access checker on any file whose path is prefixed by the argument (use \"\\\" for hh_single_type_check)"
       );
       ( "--enable-global-access-check-functions",
         Arg.String set_enable_global_access_check_functions,
-        " Run global write checker on functions listed in the given JSON file"
+        " Run global access checker on functions listed in the given JSON file"
       );
       ( "--overwrite-loop-iteration-upper-bound",
         Arg.Int (fun u -> loop_iteration_upper_bound := Some u),
@@ -965,7 +966,7 @@ let parse_options () =
           ["/"]
         else
           [])
-      ~tco_global_access_check_enabled:!enable_global_access_check
+      ~tco_global_access_check_files_enabled:!enable_global_access_check_files
       ~tco_global_access_check_functions_enabled:
         !enable_global_access_check_functions
       ~tco_use_direct_decl_parser:!use_direct_decl_parser

hphp/hack/src/options/globalOptions.ml

@@ -128,7 +128,7 @@ type t = {
   po_disallow_inst_meth: bool;
   tco_use_direct_decl_parser: bool;
   tco_ifc_enabled: string list;
-  tco_global_access_check_enabled: string list;
+  tco_global_access_check_files_enabled: string list;
   tco_global_access_check_functions_enabled: SSet.t;
   po_enable_enum_supertyping: bool;
   po_interpret_soft_types_as_like_types: bool;
@@ -268,7 +268,7 @@ let default =
     po_disallow_inst_meth = false;
     tco_use_direct_decl_parser = true;
     tco_ifc_enabled = [];
-    tco_global_access_check_enabled = [];
+    tco_global_access_check_files_enabled = [];
     tco_global_access_check_functions_enabled = SSet.empty;
     po_enable_enum_supertyping = true;
     po_interpret_soft_types_as_like_types = false;
@@ -419,7 +419,8 @@ let make
     ?(po_disallow_inst_meth = default.po_disallow_inst_meth)
     ?(tco_use_direct_decl_parser = default.tco_use_direct_decl_parser)
     ?(tco_ifc_enabled = default.tco_ifc_enabled)
-    ?(tco_global_access_check_enabled = default.tco_global_access_check_enabled)
+    ?(tco_global_access_check_files_enabled =
+      default.tco_global_access_check_files_enabled)
     ?(tco_global_access_check_functions_enabled =
       default.tco_global_access_check_functions_enabled)
     ?(po_enable_enum_supertyping = default.po_enable_enum_supertyping)
@@ -572,7 +573,7 @@ let make
     po_disallow_inst_meth;
     tco_use_direct_decl_parser;
     tco_ifc_enabled;
-    tco_global_access_check_enabled;
+    tco_global_access_check_files_enabled;
     tco_global_access_check_functions_enabled;
     po_enable_enum_supertyping;
     po_interpret_soft_types_as_like_types;

hphp/hack/src/options/globalOptions.mli

@@ -257,11 +257,11 @@ type t = {
      (a list containing the empty string would denote all files,
      an empty list denotes no files) *)
   tco_ifc_enabled: string list;
-  (* Enable global write check on the specified list of path prefixes
+  (* Enable global access check on the specified list of path prefixes
      (a list containing the empty string would denote all files,
      an empty list denotes no files) *)
-  tco_global_access_check_enabled: string list;
-  (* Enable global write check on the spcified set of functions
+  tco_global_access_check_files_enabled: string list;
+  (* Enable global access check on the spcified set of functions
      (Empty denotes no functions) *)
   tco_global_access_check_functions_enabled: SSet.t;
   (* Enables the enum supertyping extension *)
@@ -439,7 +439,7 @@ val make :
   ?po_disallow_inst_meth:bool ->
   ?tco_use_direct_decl_parser:bool ->
   ?tco_ifc_enabled:string list ->
-  ?tco_global_access_check_enabled:string list ->
+  ?tco_global_access_check_files_enabled:string list ->
   ?tco_global_access_check_functions_enabled:SSet.t ->
   ?po_enable_enum_supertyping:bool ->
   ?po_interpret_soft_types_as_like_types:bool ->

hphp/hack/src/options/typecheckerOptions.ml

@@ -155,11 +155,11 @@ let enable_ifc t = GlobalOptions.{ t with tco_ifc_enabled = ["/"] }
 
 let ifc_enabled t = t.GlobalOptions.tco_ifc_enabled
 
-let enable_global_access_check t =
-  GlobalOptions.{ t with tco_global_access_check_enabled = ["/"] }
+let enable_global_access_check_files t =
+  GlobalOptions.{ t with tco_global_access_check_files_enabled = ["/"] }
 
-let global_access_check_enabled t =
-  t.GlobalOptions.tco_global_access_check_enabled
+let global_access_check_files_enabled t =
+  t.GlobalOptions.tco_global_access_check_files_enabled
 
 let global_access_check_functions_enabled t =
   t.GlobalOptions.tco_global_access_check_functions_enabled

hphp/hack/src/oxidized/gen/global_options.rs

@@ -3,7 +3,7 @@
 // This source code is licensed under the MIT license found in the
 // LICENSE file in the "hack" directory of this source tree.
 //
-// @generated SignedSource<<618c9c7aba2f3189646de21f775d6491>>
+// @generated SignedSource<<d412f7aa311a71c04d8bef01eee2b491>>
 //
 // To regenerate this file, run:
 //   hphp/hack/src/oxidized_regen.sh
@@ -133,7 +133,7 @@ pub struct GlobalOptions {
     pub po_disallow_inst_meth: bool,
     pub tco_use_direct_decl_parser: bool,
     pub tco_ifc_enabled: Vec<String>,
-    pub tco_global_access_check_enabled: Vec<String>,
+    pub tco_global_access_check_files_enabled: Vec<String>,
     pub tco_global_access_check_functions_enabled: s_set::SSet,
     pub po_enable_enum_supertyping: bool,
     pub po_interpret_soft_types_as_like_types: bool,

hphp/hack/src/oxidized/manual/global_options_impl.rs

@@ -111,7 +111,7 @@ impl Default for GlobalOptions {
             po_disallow_inst_meth: false,
             tco_use_direct_decl_parser: true,
             tco_ifc_enabled: vec![],
-            tco_global_access_check_enabled: vec![],
+            tco_global_access_check_files_enabled: vec![],
             tco_global_access_check_functions_enabled: s_set::SSet::new(),
             po_enable_enum_supertyping: true,
             po_interpret_soft_types_as_like_types: false,

hphp/hack/src/oxidized_by_ref/gen/global_options.rs

@@ -3,7 +3,7 @@
 // This source code is licensed under the MIT license found in the
 // LICENSE file in the "hack" directory of this source tree.
 //
-// @generated SignedSource<<7f2e8a77347250323dcd3eecaca58989>>
+// @generated SignedSource<<37e03868880ffb01ac0fe62911b0bb79>>
 //
 // To regenerate this file, run:
 //   hphp/hack/src/oxidized_regen.sh
@@ -158,7 +158,7 @@ pub struct GlobalOptions<'a> {
     #[serde(deserialize_with = "arena_deserializer::arena", borrow)]
     pub tco_ifc_enabled: &'a [&'a str],
     #[serde(deserialize_with = "arena_deserializer::arena", borrow)]
-    pub tco_global_access_check_enabled: &'a [&'a str],
+    pub tco_global_access_check_files_enabled: &'a [&'a str],
     #[serde(deserialize_with = "arena_deserializer::arena", borrow)]
     pub tco_global_access_check_functions_enabled: s_set::SSet<'a>,
     pub po_enable_enum_supertyping: bool,