Skip to content
Permalink
Browse files
Handle EINTR in waitpid when hh_client starts the server
Summary:
> parent: fork(), waitpid()
> child: exit()
> macOS: SIGCHILD
> libc: EINTR
> parent:

surprisedpikachu

Reviewed By: dabek

Differential Revision: D13821803

fbshipit-source-id: 8d07185f8345f265f50c68a356bdaee9071f62ae
  • Loading branch information
fredemmott authored and hhvm-bot committed Jan 26, 2019
1 parent 59a91f5 commit afae58d676b474c0f1dafe9b949fb9e655d1619d
Showing with 1 addition and 1 deletion.
  1. +1 −1 hphp/hack/src/client/clientStart.ml
@@ -94,7 +94,7 @@ let start_server env =
Unix.create_process hh_server hh_server_args stdin stdout stderr in
Unix.close out_fd;

match Unix.waitpid [] server_pid with
match Sys_utils.waitpid_non_intr [] server_pid with
| _, Unix.WEXITED 0 ->
assert (input_line ic = ServerMonitorUtils.ready);
close_in ic

0 comments on commit afae58d

Please sign in to comment.