Permalink
Browse files

Kill tech-debt for h2tp

Summary:
We've had lengthy discussions about the maintenance of `h2tp` and `hh_matcher`. Considering that

  1. They have not been maintained and have significant features go unsupported for a while now;
  2. There are better alternatives for `hh_matcher` now that we have a full fidelity parser;
  3. Given that we want to start using the full fidelity parsers as the new front-end for quite a few of our tools, these deprecated and bit-rotting products pose too high a cost to keep;

these tools will now be removed. This diff removes `h2tp` and its associated tests from the code base.

The purpose of this diff is to stack the deletion diff for `hh_matcher` on top of this and ship them together. This is why I've simply stubbed out the `h2tp` facilities in `hh_matcher` and simply took out the three failining `hh_matcher` tests.

Reviewed By: andrewjkennedy

Differential Revision: D4802591

fbshipit-source-id: fc62450b593ec42337c3e0549846bb1c6db7177e
  • Loading branch information...
Philip Hölzenspies authored and hhvm-bot committed Apr 3, 2017
1 parent ea3e77a commit b4248a5b02781bc7287981bec855164e6f079265
Showing 346 changed files with 11 additions and 14,844 deletions.
@@ -163,11 +163,3 @@ install(PROGRAMS ${CMAKE_CURRENT_SOURCE_DIR}/bin/hackfmt
install(PROGRAMS ${CMAKE_CURRENT_SOURCE_DIR}/bin/hh_format
DESTINATION bin
COMPONENT dev)
install(PROGRAMS ${CMAKE_CURRENT_SOURCE_DIR}/bin/h2tp
DESTINATION bin
COMPONENT dev)
install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/src/h2tp/resources/
DESTINATION share/hhvm/hack/hacklib
COMPONENT dev)
@@ -199,7 +199,7 @@ begin program "hh_single_type_check"
end
begin library "hh-match"
requires = [ "hh-parsing" "hh-typing-base" "h2tp-unparser"]
requires = [ "hh-parsing" "hh-typing-base" ]
files = [
"src/hh_matcher/astConstructor.ml"
"src/hh_matcher/ast_code_extent.ml"
@@ -30,7 +30,6 @@ copy _obuild\hh_client\hh_client.asm.exe bin\hh_client.exe
copy _obuild\hh_single_type_check\hh_single_type_check.asm.exe bin\hh_single_type_check.exe
copy _obuild\hh_format\hh_format.asm.exe bin\hh_format.exe
copy _obuild\hackfmt\hackfmt.asm.exe bin\hackfmt.exe
copy _obuild\h2tp\h2tp.asm.exe bin\h2tp.exe
goto end
@@ -42,7 +41,6 @@ del bin\hh_client.exe 2>NUL
del bin\hh_single_type_check.exe 2>NUL
del bin\hh_format.exe 2>NUL
del bin\hackfmt.exe 2>NUL
del bin\h2tp.exe 2>NUL
goto end
REM execute the Hack testsuite
@@ -56,10 +56,6 @@ MODULES=\
hackfmt/line_splitter\
hackfmt\
globals\
h2tp/common\
h2tp/mapper\
h2tp/unparser\
h2tp\
hackfmt/error\
heap\
hh_matcher\
@@ -123,7 +119,7 @@ NATIVE_LIBRARIES=\
TARGETS_BASE=_build/hh_server _build/hh_client \
_build/hh_single_type_check _build/hh_emitter \
_build/hh_format _build/h2tp \
_build/hh_format \
_build/hackfmt \
_build/hh_match \
_build/code_extent_tests \
@@ -221,7 +217,6 @@ endif
cp _build/hh_emitter.$(TARGET_EXT) ../bin/hh_emitter
cp _build/hackfmt.$(TARGET_EXT) ../bin/hackfmt
cp _build/hh_format.$(TARGET_EXT) ../bin/hh_format
cp _build/h2tp/h2tp.$(TARGET_EXT) ../bin/h2tp
cp _build/hh_match.$(TARGET_EXT) ../bin/hh_match
copy-hack-files-ocp: build-hack-with-ocp
@@ -235,7 +230,6 @@ endif
cp ../_obuild/hh_single_type_check/hh_single_type_check.asm ../bin/hh_single_type_check
cp ../_obuild/hh_format/hackfmt.asm ../bin/hackfmt
cp ../_obuild/hh_format/hh_format.asm ../bin/hh_format
cp ../_obuild/h2tp/h2tp.asm ../bin/h2tp
cp ../_obuild/hh_match/hh_match.asm ../bin/hh_match
copy-match-test-files:

This file was deleted.

Oops, something went wrong.

This file was deleted.

Oops, something went wrong.

This file was deleted.

Oops, something went wrong.

This file was deleted.

Oops, something went wrong.
Oops, something went wrong.

0 comments on commit b4248a5

Please sign in to comment.