Permalink
Browse files

Ensure Nuclide debugger unregisters itself when the client detaches

Summary: Ensure the VS debugger removes itself as the active debugger if a client detaches. This will allow hphpd to then attach.

Reviewed By: mostafaeweda

Differential Revision: D6957511

fbshipit-source-id: 68245a98083a4db1278b5ea37689b6a088dc781f
  • Loading branch information...
ebluestein authored and hhvm-bot committed Feb 12, 2018
1 parent fb9f5a2 commit c373abaaf6af2cc19717f75fff43c301482d91e2
Showing with 5 additions and 0 deletions.
  1. +5 −0 hphp/runtime/ext/vsdebug/debugger.cpp
@@ -166,6 +166,11 @@ void Debugger::setClientConnected(bool connected) {
interruptAllThreads();
}
DebuggerHook::setActiveDebuggerInstance(
VSDebugHook::GetInstance(),
false
);
resumeTarget();
}
}

0 comments on commit c373aba

Please sign in to comment.