Permalink
Browse files

Fix default arguments xhp

Summary: mangle xhp classes when used as default arguments

Reviewed By: vladima

Differential Revision: D7172431

fbshipit-source-id: a56bb79f175e76b232dc835507823fb93495f90e
  • Loading branch information...
jamesjwu authored and hhvm-bot committed Mar 11, 2018
1 parent 5ee5111 commit ccb97b9779a69ec26b695cb60e10dde17adeeb65
Showing with 2 additions and 0 deletions.
  1. +2 −0 hphp/hack/src/hhbc/hhbc_hhas.ml
@@ -1064,6 +1064,8 @@ and string_of_param_default_value ~env expr =
e1 ^ s ^ e2
in
let fmt_class_name ~is_class_constant cn =
let cn = if SU.Xhp.is_xhp (Utils.strip_ns cn)
then SU.Xhp.mangle cn else cn in
let cn = (Php_escaping.escape (SU.strip_global_ns cn)) in
if is_class_constant then "\\\\" ^ cn else cn in
let get_special_class_name ~env ~is_class_constant id =

0 comments on commit ccb97b9

Please sign in to comment.