Permalink
Browse files

Do not translate functions from units marked as interpret-only.

Summary: create_function calls setInterpretOnly() but still goes to JIT in enterVM*
functions. This patch adds a check to avoid translating interpret-only functions
in shouldTranslateNoSizeLimit().

Fix #5399.
Closes #5453

Reviewed By: @jwatzman

Differential Revision: D2131171
  • Loading branch information...
wjywbs authored and jwatzman committed Jun 9, 2015
1 parent e5fc614 commit dae1f31e1bb2769455200d4537371b00101f0f17
Showing with 5 additions and 0 deletions.
  1. +5 −0 hphp/runtime/vm/jit/mc-generator.cpp
@@ -341,6 +341,11 @@ bool MCGenerator::shouldTranslateNoSizeLimit(const Func* func) const {
return false;
}
// Do not translate functions from units marked as interpret-only.
if (func->unit()->isInterpretOnly()) {
return false;
}
/*
* We don't support JIT compiling functions that use some super-dynamic php
* variables.

0 comments on commit dae1f31

Please sign in to comment.