Skip to content

Commit dae1f31

Browse files
wjywbsjwatzman
authored andcommitted
Do not translate functions from units marked as interpret-only.
Summary: create_function calls setInterpretOnly() but still goes to JIT in enterVM* functions. This patch adds a check to avoid translating interpret-only functions in shouldTranslateNoSizeLimit(). Fix #5399. Closes #5453 Reviewed By: @jwatzman Differential Revision: D2131171
1 parent e5fc614 commit dae1f31

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

hphp/runtime/vm/jit/mc-generator.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -341,6 +341,11 @@ bool MCGenerator::shouldTranslateNoSizeLimit(const Func* func) const {
341341
return false;
342342
}
343343

344+
// Do not translate functions from units marked as interpret-only.
345+
if (func->unit()->isInterpretOnly()) {
346+
return false;
347+
}
348+
344349
/*
345350
* We don't support JIT compiling functions that use some super-dynamic php
346351
* variables.

0 commit comments

Comments
 (0)