Skip to content

Commit

Permalink
Do not translate functions from units marked as interpret-only.
Browse files Browse the repository at this point in the history
Summary: create_function calls setInterpretOnly() but still goes to JIT in enterVM*
functions. This patch adds a check to avoid translating interpret-only functions
in shouldTranslateNoSizeLimit().

Fix #5399.
Closes #5453

Reviewed By: @jwatzman

Differential Revision: D2131171
  • Loading branch information
wjywbs authored and jwatzman committed Jun 9, 2015
1 parent e5fc614 commit dae1f31
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions hphp/runtime/vm/jit/mc-generator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,11 @@ bool MCGenerator::shouldTranslateNoSizeLimit(const Func* func) const {
return false;
}

// Do not translate functions from units marked as interpret-only.
if (func->unit()->isInterpretOnly()) {
return false;
}

/*
* We don't support JIT compiling functions that use some super-dynamic php
* variables.
Expand Down

0 comments on commit dae1f31

Please sign in to comment.