Please sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Compare default values of parameters by re-parsing them.
Summary: Currently checking default values is as significant missing piece in semdiff - we used to compare them as strings using some minor normalization rules but many aspects that don't affect semantics (like trailing commas) were still reported as errors. In this diff we check default values by parsing and lowering them, normalizing lowered trees and then comparing string representation of syntax trees. Using this approach already allowed to: - discover corner case in parser related to recognizing `$` token - find incorrect output for default values containing XHP - discover issue related to incorrect representation of special characters in default values All these issues are fixed in this diff. Reviewed By: nbenton Differential Revision: D7227814 fbshipit-source-id: 75b71a73d97586736660cc0ecf6ebd7a9110b1c7
- Loading branch information
Showing with 102 additions and 37 deletions.