HHVM Debugger: Fixup output event types

Summary: This tightens up the types of output events to match those supported by VS Code. Reviewed By: mostafaeweda Differential Revision: D7117073 fbshipit-source-id: 8bd485449b1e6ae943c12597569f85f93ec3add6
facebook · Mar 5, 2018 · ff00708 · ff00708
1 parent 851e9c1
commit ff00708
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/hphp/runtime/ext/vsdebug/session.cpp b/hphp/runtime/ext/vsdebug/session.cpp
@@ -219,6 +219,11 @@ void DebuggerSession::runDummy() {
       VSDebugLogger::LogLevelWarning,
       "Dummy request started without a startup document."
     );
+    m_debugger->sendUserMessage(
+      "No startup document was specified, not loading any Hack/PHP "
+        "types for the console.",
+      DebugTransport::OutputLevelWarning
+    );
   }
 
   m_dummyRequestInfo->m_commandQueue.processCommands();

diff --git a/hphp/runtime/ext/vsdebug/transport.h b/hphp/runtime/ext/vsdebug/transport.h
@@ -85,8 +85,8 @@ struct DebugTransport {
   //    they do not understand.
   static constexpr char* OutputLevelSuccess = "success";
   static constexpr char* OutputLevelInfo = "info";
-  static constexpr char* OutputLevelWarning = "warning";
-  static constexpr char* OutputLevelError = "error";
+  static constexpr char* OutputLevelWarning = "console";
+  static constexpr char* OutputLevelError = "stderr";
   static constexpr char* OutputLevelLog = "console";
   static constexpr char* OutputLevelStdout = "stdout";
   static constexpr char* OutputLevelStderr = "stderr";