Skip to content
Permalink
Branch: master
Commits on Apr 24, 2019
  1. Fix handling for mergeOnly units

    paulbiss authored and hhvm-bot committed Apr 24, 2019
    Summary: The per-unit litstr table is initialized below these lines, meaning it's only safe to do this when litstrs are in the global table. Use the UnitEmitter version instead.
    
    Reviewed By: ricklavoie
    
    Differential Revision: D15055196
    
    fbshipit-source-id: 9f0d9d0828e392e2d670e559cb98b621f2015605
  2. Lazy initialization for Func::m_fullName

    paulbiss authored and hhvm-bot committed Apr 24, 2019
    Summary: We often don't need these for methods on traits, methods which are never invoked, and methods which we never take backtraces to. The form of makeStaticString used avoid constructing a request local string first making this code safe for profilers to call.
    
    Reviewed By: ricklavoie
    
    Differential Revision: D15051447
    
    fbshipit-source-id: c7a31fda03131f88fd413a68f9a25705b6a4012c
Commits on Apr 23, 2019
  1. Move func/class pointer warnings into verifyFail()

    paulbiss authored and hhvm-bot committed Apr 23, 2019
    Summary: TypeConstraint::check() doesn't always run from contexts that can reenter. Also fix a bug where conversion warnings were printed for properties despite not actually performing a conversion.
    
    Reviewed By: ricklavoie
    
    Differential Revision: D15032723
    
    fbshipit-source-id: e20dccbfe37432d71810de585c3b3a22246c236e
Commits on Apr 22, 2019
  1. Add some functions for evaluating sandbox requests

    paulbiss authored and hhvm-bot committed Apr 22, 2019
    Reviewed By: ricklavoie
    
    Differential Revision: D15010046
    
    fbshipit-source-id: 0406bdc316ddcb3a2658a589d687e741ed0a8d38
Commits on Apr 19, 2019
  1. Stop binding refs into args array for fb_intercept with inout handlers

    paulbiss authored and hhvm-bot committed Apr 19, 2019
    Summary: They already return the arguments array back out as an `inout` parameter.
    
    Reviewed By: jano
    
    Differential Revision: D14999692
    
    fbshipit-source-id: 01bf885731d343e24d75958db022d6a6f04e48e7
  2. Handle inout closures in fb_intercept

    paulbiss authored and hhvm-bot committed Apr 19, 2019
    Summary: Closures are strange. We don't ever create reffy-wrappers for `__invoke` instead the canonical wrapper is always the inout function.
    
    Reviewed By: ricklavoie
    
    Differential Revision: D14961885
    
    fbshipit-source-id: 446807acc805faa44fd5e199940c0f0c054dd7e4
  3. Suppress HAC ref-bind notices when setting up fb_intercept

    paulbiss authored and hhvm-bot committed Apr 19, 2019
    Summary: It's doing an `appendRef` but the array isn't leaking anywhere, it's just being used in `invokeFunc`. The argument array (which gets created with `appendWithRef` does leak to the function doing an intercept but only contains refs when intercepting a function that's already pass-by-ref.
    
    Reviewed By: ricklavoie
    
    Differential Revision: D14961879
    
    fbshipit-source-id: e236bdf60d55859bc528a95e15d591351cc8581d
Commits on Apr 17, 2019
  1. Remove some unnecessary setWithRef() calls

    paulbiss authored and hhvm-bot committed Apr 17, 2019
    Summary: They were always being called with either objects or primitives.
    
    Reviewed By: billf
    
    Differential Revision: D14894417
    
    fbshipit-source-id: 1cb2c5ada0301b46edee999081c773c44b36163d
  2. Remove (Set|Append)Ref(InPlace)? functions from Array types

    paulbiss authored and hhvm-bot committed Apr 17, 2019
    Summary: youredeadtome
    
    Reviewed By: jano, alexeyt
    
    Differential Revision: D14884607
    
    fbshipit-source-id: f0c858a20258e8136be2855aff3777200f9e7fcf
  3. Remove last use of setRef()

    paulbiss authored and hhvm-bot committed Apr 17, 2019
    Summary: This is hacky but it's the last place using `setRef()` and we need to think up an alternative API for www to replace it. In the meantime I'd like to kill the `(set|append)Ref` functions on the various array classes.
    
    Reviewed By: billf
    
    Differential Revision: D14884601
    
    fbshipit-source-id: 31ebd2358277fd97cac37c5dffe08c78d5f0c81d
  4. Drop support for reffy array/collection initializers

    paulbiss authored and hhvm-bot committed Apr 17, 2019
    Summary: Make it a parse error, and delete the AddElemV and AddNewElemV bytecodes (which are now unused). Hilariously, if you bound refs in to a `Vector{}` we would emit bytecode that would fail to verify so this fixes that too.
    
    Reviewed By: oulgen, alexeyt
    
    Differential Revision: D14884593
    
    fbshipit-source-id: 89d2acf6c52de4b441ed3e47840ca515c164c0e3
  5. Stop constructing arrays containing refs in tests

    paulbiss authored and hhvm-bot committed Apr 17, 2019
    Summary: D14884593 will drop support for these constructors, and more generally we're getting very close to dropping refs from arrays entirely
    
    Reviewed By: periodic1236, alexeyt
    
    Differential Revision: D14884589
    
    fbshipit-source-id: 555fdae870160f4597e22d224fe8db0b8b6245a7
  6. Drop support for [:] and [@] substitutions from ini parsing

    paulbiss authored and hhvm-bot committed Apr 17, 2019
    Summary: These features were implemented using refs, and aren't part of the standard INI implementation. Additionally section parsing was implemented using refs but was easy to tweak.
    
    Reviewed By: billf
    
    Differential Revision: D14884584
    
    fbshipit-source-id: 7a557269ebffe9442c01c9022abace35a636d432
  7. Stop binding refs into arrays in SOAP

    paulbiss authored and hhvm-bot committed Apr 17, 2019
    Summary: As with mysqli there was no reason that we needed to store these refs into an `Array`. In fact in this case we were using one array to map from `xmlNodePtr` to `RefData`/`ObjectData` **and** using the same array as a reverse mapping (casting pointers to `int64_t` in the process). This diff switches to `req` containers and keys on `HeapObject*` instead so that these roots are visible to the GC.
    
    Reviewed By: ricklavoie
    
    Differential Revision: D14884579
    
    fbshipit-source-id: e0fab70efdc783a8c42de3004d6a7637cf4a6e7a
  8. Stop binding refs into arrays in mysqli

    paulbiss authored and hhvm-bot committed Apr 17, 2019
    Summary: Rather than use an `Array` to store bound parameters just use a `req::vector<req::ptr<RefData>>`. Eventually we will need to kill this extension entirely as it doesn't make much sense without refs. fredemmott thinks it will be safe to do this at the end of June. Until then, this diff at least addresses the fact that we're binding refs into arrays.
    
    Reviewed By: billf
    
    Differential Revision: D14884573
    
    fbshipit-source-id: 3949b2f898200adf6ff117e3b0538cb14ef39d95
  9. Stop passing context by reference to SQLite3::createaggregate() callb…

    paulbiss authored and hhvm-bot committed Apr 17, 2019
    …acks
    
    Summary: Doesn't look like not passing the context by reference would fundamentally brick this API.
    
    Reviewed By: billf, alexeyt
    
    Differential Revision: D14884567
    
    fbshipit-source-id: 71134bca7cfc720330f8c01c59d17b802b5f4dfb
  10. Remove support for callbacks from Memcached::get() and Memcached::get…

    paulbiss authored and hhvm-bot committed Apr 17, 2019
    …bykey()
    
    Summary: API depends on pass by ref.
    
    Reviewed By: billf, alexeyt
    
    Differential Revision: D14884563
    
    fbshipit-source-id: defeda56634981e7043d844f2f726f15226c3550
  11. Remove support for FILTER_CALLBACK

    paulbiss authored and hhvm-bot committed Apr 17, 2019
    Summary: Does a call by ref.
    
    Reviewed By: billf
    
    Differential Revision: D14884558
    
    fbshipit-source-id: 94dd002e48b902f11bf43dd17e5d9dfdc85a6e97
  12. Remove dead UserFile/UserDirectory classes

    paulbiss authored and hhvm-bot committed Apr 17, 2019
    Summary: Killed in D14418046
    
    Reviewed By: billf, efiks, alexeyt
    
    Differential Revision: D14884550
    
    fbshipit-source-id: 5df6ef68c4dec68aa2412fc71c9eddc1063995f5
  13. Delete ExecutionContext::getContextClass() and ExecutionContext::getP…

    paulbiss authored and hhvm-bot committed Apr 17, 2019
    …arentContextClass()
    
    Summary: These were the last users, and this new API is safer (because of inlining) anyway.
    
    Reviewed By: ricklavoie
    
    Differential Revision: D14860515
    
    fbshipit-source-id: 8d1f6bd4b21e6112d7d85196200ed426dd435fd7
Commits on Apr 16, 2019
  1. Fix OODeclExists irgen

    paulbiss authored and hhvm-bot committed Apr 16, 2019
    Summary: It was always punting.
    
    Reviewed By: markw65
    
    Differential Revision: D14943006
    
    fbshipit-source-id: 7e7fa6a80ba93430d7267130415c85cce697bd9a
Commits on Apr 5, 2019
  1. KindOfClass and KindOfFunc fixes

    paulbiss authored and hhvm-bot committed Apr 5, 2019
    Reviewed By: markw65
    
    Differential Revision: D14290332
    
    fbshipit-source-id: de1e5d45065386581bfff971642fef17936b87b8
Commits on Apr 4, 2019
  1. Correctly initialize m_nextKI in MixedArray::MakeDArrayNatural

    paulbiss authored and hhvm-bot committed Apr 4, 2019
    Reviewed By: mxw, alexeyt, viratyosin
    
    Differential Revision: D14762620
    
    fbshipit-source-id: 9f1b75812289a9dba84c06839f064c8118ecadf3
Commits on Apr 3, 2019
  1. Fix reentrancy bug in APC

    paulbiss authored and hhvm-bot committed Apr 3, 2019
    Summary: Calling `toLocal()` on a serialized APC value containing objects may trigger the autoloader.
    
    Reviewed By: mofarrell
    
    Differential Revision: D14713435
    
    fbshipit-source-id: 7e66a990247c2ad1c2144c583e221d0251069fd1
Commits on Mar 27, 2019
  1. Suppress OOMs when extracting constants from HHAS

    paulbiss authored and hhvm-bot committed Mar 27, 2019
    Summary: Rather than allowing OOMs to propagate out of the unserializer set a configurable maximum size for any one constant and use that to determine whether or not to create a fatal unit. Also fix a few places where units are loaded so that they can be read into memory/loaded from the repo without generating an OOM.
    
    Reviewed By: ricklavoie
    
    Differential Revision: D14532703
    
    fbshipit-source-id: 8a8c9a29a0211ac03561c2bf5e7dc43c1c88d1d4
Commits on Mar 24, 2019
  1. Back out "Temporarily re-add static locals"

    paulbiss authored and hhvm-bot committed Mar 24, 2019
    Summary: Original commit changeset: 02c576127292
    
    Reviewed By: alexeyt
    
    Differential Revision: D14590747
    
    fbshipit-source-id: a93dfb0f632880c4914f3df07870b541aeaba7e4
Commits on Mar 20, 2019
  1. Revert D14525755: [trivial] flip ints overflow to ints default

    paulbiss authored and hhvm-bot committed Mar 20, 2019
    Differential Revision:
    D14525755
    
    Original commit changeset: 12fc10f4c3df
    
    fbshipit-source-id: 02263d6970a64ef9f5dc344a212a2077353a583a
Commits on Mar 19, 2019
  1. Revert D14515120: Remove reference to PHAR extension files

    paulbiss authored and hhvm-bot committed Mar 19, 2019
    Differential Revision:
    D14515120
    
    Original commit changeset: 5e5e1604a1aa
    
    fbshipit-source-id: 071e7c8acad257cbd1637775f65f825262aa3773
Commits on Mar 18, 2019
  1. Remove remaining runtime support for static locals

    paulbiss authored and hhvm-bot committed Mar 18, 2019
    Reviewed By: ricklavoie
    
    Differential Revision: D14317192
    
    fbshipit-source-id: 8bd9def3fcc09a164aca5099b4584194946c9737
  2. Remove hhbbc support for static locals

    paulbiss authored and hhvm-bot committed Mar 18, 2019
    Reviewed By: ricklavoie
    
    Differential Revision: D14317182
    
    fbshipit-source-id: 5b1b649ab6d63456f387bd49c7a8ea246f84e6dd
  3. Remove rds support for static locals

    paulbiss authored and hhvm-bot committed Mar 18, 2019
    Reviewed By: ricklavoie
    
    Differential Revision: D14317167
    
    fbshipit-source-id: 4835d835f98347b7e1f7534f96bbb2e0db09b939
  4. Remove extension support for static locals

    paulbiss authored and hhvm-bot committed Mar 18, 2019
    Reviewed By: ricklavoie
    
    Differential Revision: D14317155
    
    fbshipit-source-id: ee3d54db85cf9a5772c03553812bf6787f9eeba4
  5. Remove IR instructions for static locals

    paulbiss authored and hhvm-bot committed Mar 18, 2019
    Reviewed By: ricklavoie
    
    Differential Revision: D14317134
    
    fbshipit-source-id: 9877255c0836615ffc227295f12580d8c2821f27
  6. Remove bytecodes for static locals

    paulbiss authored and hhvm-bot committed Mar 18, 2019
    Reviewed By: ricklavoie
    
    Differential Revision: D14317119
    
    fbshipit-source-id: 62045e6d705b20eda6821eb4dc3dce898d7e0083
  7. Remove options for static locals

    paulbiss authored and hhvm-bot committed Mar 18, 2019
    Reviewed By: ricklavoie
    
    Differential Revision: D14317098
    
    fbshipit-source-id: 14dfefaa04116466464d2b05680b38066ac3e443
Older
You can’t perform that action at this time.