Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case insensitive constants not supported #129

Closed
chrisgraham opened this issue Jul 18, 2010 · 3 comments
Closed

Case insensitive constants not supported #129

chrisgraham opened this issue Jul 18, 2010 · 3 comments

Comments

@chrisgraham
Copy link

'define' allows you to make case-insensitive constants, but hphp does not support this (it ignores the parameter).

As far as I'm concerned it's a horrid PHP feature so would be tempted just to document it as a an accepted difference in behaviour.

@alevensalor
Copy link

I would second documenting it as unsupported in HPHP. If horrid had an ugly little sister, case-insensitive constants would call her a bitch for being so hot.

@sgolemon
Copy link
Contributor

I expect your take on this is going to be the case. It'd be pretty trivial under HHVM, but a PITA under HPHPc. Regardless of the implementation details, it is horrid's ugly little sibling and as such probably only worth of documenting under "differences from PHP".

I'm going to leave this open for now though, as it's worth keeping on the table.

@ptarjan
Copy link
Contributor

ptarjan commented May 13, 2013

We're closing out all bugs older than 2 months. http://www.hiphop-php.com/wp/?p=575

If this is still an issue, please re-open it, and in order of goodness:

  1. Give detailed repro steps
  2. Write a test case in hphp/tests/quick (run it with hphp/tests/run) and send the pull request
  3. Fix it in a pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants