New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PATH_INFO #315

Closed
tstarling opened this Issue Apr 5, 2011 · 5 comments

Comments

Projects
None yet
6 participants
@tstarling
Contributor

tstarling commented Apr 5, 2011

Please support the CGI "PATH_INFO" feature, which allows URLs such as /index.php/Foo, interpreted as an invocation of /index.php with $_SERVER['PATH_INFO'] = '/Foo'. Most installations of MediaWiki use this feature to provide "pretty" URLs.

Alternatively, allow compilation as a FastCGI server so that the webserver can implement this and many other useful HTTP features.

@iamacarpet

This comment has been minimized.

iamacarpet commented Jul 23, 2012

+1 on the FastCGI.

@ptarjan

This comment has been minimized.

Contributor

ptarjan commented May 13, 2013

We're closing out all bugs older than 2 months. http://www.hiphop-php.com/wp/?p=575

If this is still an issue, please re-open it, and in order of goodness:

  1. Give detailed repro steps
  2. Write a test case in hphp/tests/quick (run it with hphp/tests/run) and send the pull request
  3. Fix it in a pull request

@ptarjan ptarjan closed this May 13, 2013

@nyurik

This comment has been minimized.

nyurik commented Aug 11, 2013

Is path_info supported by hiphop? I am debating to use this feature as part of the core MediaWiki API as it makes api much cleaner from a number of perspectives, and WMF is considering migrating to hiphop.

@danslo

This comment has been minimized.

Contributor

danslo commented Aug 11, 2013

$ grep PATH_INFO -Rin hphp/
...
hphp//runtime/server/http_protocol.cpp:377:    server.set(s_PATH_INFO, r.pathInfo());

Looks like it... Just test it? :)

@scannell

This comment has been minimized.

Contributor

scannell commented Aug 12, 2013

@danslo is right, it appears that it is implemented. Are you asking because you had a problem with it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment