New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we make phpinfo() better? #4678

Closed
JoelMarcey opened this Issue Jan 20, 2015 · 11 comments

Comments

Projects
None yet
9 participants
@Majkl578

This comment has been minimized.

Show comment
Hide comment
@Majkl578

Majkl578 Jan 21, 2015

Contributor

👍

Contributor

Majkl578 commented Jan 21, 2015

👍

@reeze

This comment has been minimized.

Show comment
Hide comment
@reeze

reeze Jan 21, 2015

Contributor

👍 I will try to improve it. There always someone asking what happened when he trying to test HHVM.

Contributor

reeze commented Jan 21, 2015

👍 I will try to improve it. There always someone asking what happened when he trying to test HHVM.

@reeze

This comment has been minimized.

Show comment
Hide comment
@reeze

reeze Jan 21, 2015

Contributor

Sorry I didn't notice that @JoelMarcey already self-assigned :) @JoelMarcey will be a better man to do the ini thing.

Contributor

reeze commented Jan 21, 2015

Sorry I didn't notice that @JoelMarcey already self-assigned :) @JoelMarcey will be a better man to do the ini thing.

@nwalke

This comment has been minimized.

Show comment
Hide comment
@nwalke

nwalke Feb 1, 2015

For others looking for a quick way to check settings: https://gist.github.com/ck-on/67ca91f0310a695ceb65

nwalke commented Feb 1, 2015

For others looking for a quick way to check settings: https://gist.github.com/ck-on/67ca91f0310a695ceb65

jwatzman added a commit that referenced this issue Apr 16, 2015

Simple implementation of phpinfo()
Summary: For CLI only, and doesn't use the `$what` var, but better than
nothing. Involved exposing a couple of constants that at first I thought
we might not want to expose, but then figured they could be useful for
logging, and anyone using them for prod gets what they deserve.

A fun hackathon project :)

Ref. #4678

Reviewed By: @paulbiss

Differential Revision: D1981690
@shehi

This comment has been minimized.

Show comment
Hide comment
@shehi

shehi Jun 25, 2015

Jan 20th... Hmm...

shehi commented Jun 25, 2015

Jan 20th... Hmm...

@SiebelsTim

This comment has been minimized.

Show comment
Hide comment
@SiebelsTim

SiebelsTim Jun 25, 2015

Contributor

@shehi This actually got better in 57b7c37
Maybe this can be closed even.

Contributor

SiebelsTim commented Jun 25, 2015

@shehi This actually got better in 57b7c37
Maybe this can be closed even.

@Orvid

This comment has been minimized.

Show comment
Hide comment
@Orvid

Orvid Jun 26, 2015

Contributor

It still doesn't output compilation options or what extensions were compiled in though. The former should be relatively simple to implement, but the latter will take a significant refactor of the extension build setup.

Contributor

Orvid commented Jun 26, 2015

It still doesn't output compilation options or what extensions were compiled in though. The former should be relatively simple to implement, but the latter will take a significant refactor of the extension build setup.

@jwatzman

This comment has been minimized.

Show comment
Hide comment
@jwatzman

jwatzman Jul 6, 2015

Member

Yeah, I don't consider this finished, just with a "quick fix" in place. Feel free to send a PR to add more stuff if you want it, but I'm not actively working on this right now.

Member

jwatzman commented Jul 6, 2015

Yeah, I don't consider this finished, just with a "quick fix" in place. Feel free to send a PR to add more stuff if you want it, but I'm not actively working on this right now.

@Orvid

This comment has been minimized.

Show comment
Hide comment
@Orvid

Orvid Jul 6, 2015

Contributor

Well, with #5571 there is slightly more reason to implement the extension side. It can probably be done with the existing extension registry, although I've not looked at what exactly it provides.

Compiler options should be easy to implement in CMake, but how hard would it be for FB's build?

Contributor

Orvid commented Jul 6, 2015

Well, with #5571 there is slightly more reason to implement the extension side. It can probably be done with the existing extension registry, although I've not looked at what exactly it provides.

Compiler options should be easy to implement in CMake, but how hard would it be for FB's build?

@jwatzman

This comment has been minimized.

Show comment
Hide comment
@jwatzman

jwatzman Jul 6, 2015

Member

Compiler options should be easy to implement in CMake, but how hard would it be for FB's build?

Probably irrelevant for FB's purposes, we have a very uniform build system and so this info is much less useful for us, and we probably aren't going to be using phpinfo() anyways. As long as it doesn't break in our builds, it's fine.

Member

jwatzman commented Jul 6, 2015

Compiler options should be easy to implement in CMake, but how hard would it be for FB's build?

Probably irrelevant for FB's purposes, we have a very uniform build system and so this info is much less useful for us, and we probably aren't going to be using phpinfo() anyways. As long as it doesn't break in our builds, it's fine.

@paulbiss

This comment has been minimized.

Show comment
Hide comment
@paulbiss

paulbiss Sep 28, 2016

Contributor

Going to close this issue as the general functionality has been improved. If there are specific features anyone needs please open issues for them.

Contributor

paulbiss commented Sep 28, 2016

Going to close this issue as the general functionality has been improved. If there are specific features anyone needs please open issues for them.

@paulbiss paulbiss closed this Sep 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment