Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Build fails at ext_memcache.cpp with libmemcached 1.0.10 #560

Closed
dcelasun opened this Issue · 10 comments

8 participants

@dcelasun

Exactly what it says in the title. Any ideas?

[ 42%] Building CXX object src/CMakeFiles/hphp_runtime_static.dir/runtime/ext/ext_memcache.cpp.o
/home/dcelasun/builds/hiphop-git/src/hiphop-php/src/runtime/ext/ext_memcache.cpp: In member function ‘HPHP::Variant HPHP::c_Memcache::t_getversion()’:
/home/dcelasun/builds/hiphop-git/src/hiphop-php/src/runtime/ext/ext_memcache.cpp:378:18: error: invalid use of incomplete type ‘const struct org::libmemcached::Instance’
/usr/include/libmemcached-1.0/types.h:43:49: error: forward declaration of ‘const struct org::libmemcached::Instance’
/home/dcelasun/builds/hiphop-git/src/hiphop-php/src/runtime/ext/ext_memcache.cpp:383:17: error: invalid use of incomplete type ‘const struct org::libmemcached::Instance’
/usr/include/libmemcached-1.0/types.h:43:49: error: forward declaration of ‘const struct org::libmemcached::Instance’
/home/dcelasun/builds/hiphop-git/src/hiphop-php/src/runtime/ext/ext_memcache.cpp:383:42: error: invalid use of incomplete type ‘const struct org::libmemcached::Instance’
/usr/include/libmemcached-1.0/types.h:43:49: error: forward declaration of ‘const struct org::libmemcached::Instance’
/home/dcelasun/builds/hiphop-git/src/hiphop-php/src/runtime/ext/ext_memcache.cpp:384:17: error: invalid use of incomplete type ‘const struct org::libmemcached::Instance’
/usr/include/libmemcached-1.0/types.h:43:49: error: forward declaration of ‘const struct org::libmemcached::Instance’
/home/dcelasun/builds/hiphop-git/src/hiphop-php/src/runtime/ext/ext_memcache.cpp: In member function ‘HPHP::Array HPHP::c_Memcache::t_getstats(HPHP::CStrRef, int, int)’:
/home/dcelasun/builds/hiphop-git/src/hiphop-php/src/runtime/ext/ext_memcache.cpp:484:61: error: invalid use of incomplete type ‘const struct org::libmemcached::Instance’
/usr/include/libmemcached-1.0/types.h:43:49: error: forward declaration of ‘const struct org::libmemcached::Instance’
/home/dcelasun/builds/hiphop-git/src/hiphop-php/src/runtime/ext/ext_memcache.cpp:485:41: error: invalid use of incomplete type ‘const struct org::libmemcached::Instance’
/usr/include/libmemcached-1.0/types.h:43:49: error: forward declaration of ‘const struct org::libmemcached::Instance’
/home/dcelasun/builds/hiphop-git/src/hiphop-php/src/runtime/ext/ext_memcache.cpp: In member function ‘HPHP::Array HPHP::c_Memcache::t_getextendedstats(HPHP::CStrRef, int, int)’:
/home/dcelasun/builds/hiphop-git/src/hiphop-php/src/runtime/ext/ext_memcache.cpp:524:39: error: invalid use of incomplete type ‘const struct org::libmemcached::Instance’
/usr/include/libmemcached-1.0/types.h:43:49: error: forward declaration of ‘const struct org::libmemcached::Instance’
/home/dcelasun/builds/hiphop-git/src/hiphop-php/src/runtime/ext/ext_memcache.cpp:524:57: error: invalid use of incomplete type ‘const struct org::libmemcached::Instance’
/usr/include/libmemcached-1.0/types.h:43:49: error: forward declaration of ‘const struct org::libmemcached::Instance’
make[2]: *** [src/CMakeFiles/hphp_runtime_static.dir/runtime/ext/ext_memcache.cpp.o] Error 1
make[1]: *** [src/CMakeFiles/hphp_runtime_static.dir/all] Error 2
make: *** [all] Error 2

@dcelasun

Building with libmemcached 0.5.3 works, so this is definitely a 1.x bug.

@sgolemon
Owner

Hrmmm... non-trivial set of fixes to be done there. Hang in there with libmemcached 0.x and I'll put this on the list.

@sgolemon sgolemon was assigned
@thedjnK

The bug was introduced with libmemcached 1.0.8, it still compiles fine if you use 1.0.7.

@sgolemon
Owner

Thanks @thedjnK, good to know!

@calebgray

I can confirm that this is still an open issue, and that using 1.0.7 is still the solution.

@ptarjan
Owner

We're closing out all bugs older than 2 months. http://www.hiphop-php.com/wp/?p=575

If this is still an issue, please re-open it, and in order of goodness:

  1. Give detailed repro steps
  2. Write a test case in hphp/tests/quick (run it with hphp/tests/run) and send the pull request
  3. Fix it in a pull request
@ptarjan ptarjan closed this
@tgabi333

This problem still exists, I've tried to build hiphop from source on wheezy with libmemcached-dev=1.0.16-1 (from dotdeb repository) and the same error happened, but it worked with libmemcached-1.0.7 (built from source).

@ptarjan
Owner

@tgabi333 do you understand the memcache source enough to offer a fix? If it is a point release that broke it, it is probably simple.

@danslo

FYI this also requires a work-around when building on OSX. But not a huge problem.

@seyfer

@tgabi333, i'm have the same error.

I'm install libmemcached-dev=1.0.16 from sources, becouse
pecl install memcached

needs this library.
but when i'm do

dpkg -s libmemcached-dev

It's print
Source: libmemcached
Version: 1.0.8-1

Now i need build 1.0.7 from SOURCE? This is not broke my memcached?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.