Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hiphop does not build in OSX. #780

Closed
danslo opened this issue May 17, 2013 · 7 comments
Closed

Hiphop does not build in OSX. #780

danslo opened this issue May 17, 2013 · 7 comments
Labels
build

Comments

@danslo
Copy link
Contributor

danslo commented May 17, 2013

I will use this issue to keep track of OSX related pull requests / issues.
@danslo
Copy link
Contributor Author

danslo commented May 17, 2013

#741

@danslo
Copy link
Contributor Author

danslo commented May 17, 2013

#770

@danslo
Copy link
Contributor Author

danslo commented May 17, 2013

Folly needs the following merged and updated in hphp:
facebook/folly#27

@ptarjan
Copy link
Contributor

ptarjan commented May 17, 2013

Why is #741 needed for OSX?

@danslo
Copy link
Contributor Author

danslo commented May 17, 2013

@ptarjan: Because I accidentally added 3 unrelated fixes together. See the commit at the bottom of that PR:
danslo@ca23bef

@ptarjan
Copy link
Contributor

ptarjan commented May 17, 2013

Can you do a git push -f and clean things up?

@danslo
Copy link
Contributor Author

danslo commented May 17, 2013

I have created two separate PRs, closing this one.

@danslo danslo closed this as completed May 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ptarjan @danslo