Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify hhvm.server.default_document more than once #7817

Open
Amitie10g opened this issue Apr 30, 2017 · 3 comments

Comments

@Amitie10g
Copy link

commented Apr 30, 2017

I'm running a tool in the Wikimedia Tool Labs and I proposed to add HHVM in server mode as one of the flavours of Kubernetes containers.

The implementation of HHVM in Proxygen mode seems fine, but I found an issue with the hhvm.server.default_document option: It can be set only once, and I'm unable to configure, for example, "index.html" in addition to "index.php", throwing a 404 error when accessing an URL without an index.php file but with an index.html one.

HHVM Version

3.12.7

@mofarrell

This comment has been minimized.

Copy link
Contributor

commented May 1, 2017

It currently only supports one default document type. Is this blocking switching from fastcgi to proxygen?

@Amitie10g

This comment has been minimized.

Copy link
Author

commented May 2, 2017

There are plans to implement HHVM in FastCGI mode with lighttpd, but this is not a priority task.

¿Is there plans to implement more than one default document in Proxygen mode?

@mofarrell

This comment has been minimized.

Copy link
Contributor

commented May 2, 2017

We actually recommend running with proxygen over fastcgi (its faster). However, I don't believe we have any plans to allow a set of default documents. We would most likely accept a pull request for it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.