Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug running CMAKE. #2225

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
10 participants
@daohoangson
Copy link

commented Mar 29, 2014

Changed HHVM_LINK_LIBRARIES and HHVM_EXTENSION macros to functions.

Fixed bug running CMAKE.
Changed HHVM_LINK_LIBRARIES and HHVM_EXTENSION macros to functions.
@sinaa

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2014

Thanks for this @daohoangson . I can also confirm that this fixes the broken cmake. (Centos 6.5)

@cuppett

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2014

This fixed CMake for me on Fedora 20 as well.

@sumitk1

This comment has been minimized.

Copy link

commented Mar 29, 2014

Thanks @daohoangson ! I just tested it on Ubuntu 13.10 VM and its fixed.

@jrahmy

This comment has been minimized.

Copy link

commented Mar 29, 2014

+1

@C0mkid

This comment has been minimized.

Copy link

commented Mar 30, 2014

Thanks, fixed for me on Ubuntu 14.04

@shivaas

This comment has been minimized.

Copy link

commented Mar 30, 2014

This fixes the CMake on Ubuntu 12.04 LTS as well

@gzanthony

This comment has been minimized.

Copy link

commented Mar 30, 2014

This fixes the CMake on CentOS 6.4 x64 as well

@Oeverwal

This comment has been minimized.

Copy link

commented Mar 30, 2014

Fixes broken cmake on CentOS 6.5 x86.

@reeze reeze referenced this pull request Mar 31, 2014

Merged

Fix CMake files #2246

@ptarjan

This comment has been minimized.

Copy link
Contributor

commented Mar 31, 2014

You haven't signed a CLA yet (see our contributing document), so I can't review your code, but I assume this isn't needed now that I merged #2246 . Please re-open if this isn't the case.

@ptarjan ptarjan closed this Mar 31, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.