Skip to content

Improved the Zend compatibility for ReflectionClass #3233

Closed
wants to merge 1 commit into from

2 participants

@stof
stof commented Jul 18, 2014

inNamespace(), getNamespaceName(), and getShortName() should not be final. This was causing issues in phpspec which mocks these methods.

This was done for ReflectionFunctionAbstract in #3070 but ReflectionClass was missed

@stof stof Improved the Zend compatibility for ReflectionClass
inNamespace()`, `getNamespaceName()`, and `getShortName()` should not be `final`. This was causing issues in phpspec which mocks these methods.
4a7e17c
@stof stof added a commit to phpspec/prophecy that referenced this pull request Jul 18, 2014
@stof stof Added hhvm-nightly in the allowed failures on Travis
This should be reverted once facebook/hhvm#3233 is
fixed.
328484c
@facebook-github-bot

This pull request has been imported into Phabricator, and discussion and review of the diff will take place at https://reviews.facebook.net/D20223

@facebook-github-bot facebook-github-bot added a commit that closed this pull request Jul 20, 2014
svcscm Improved the Zend compatibility for ReflectionClass
Summary: `inNamespace()`, `getNamespaceName()`, and `getShortName()` should not be `final`. This was causing issues in phpspec which mocks these methods.

This was done for ReflectionFunctionAbstract in #3070 but ReflectionClass was missed

Closes #3233

Reviewed By: @ptarjan

Differential Revision: D1445618
8c10077
@stof stof deleted the stof:patch-1 branch Aug 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.