Improved the Zend compatibility for ReflectionClass #3233

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@stof
Contributor

stof commented Jul 18, 2014

inNamespace(), getNamespaceName(), and getShortName() should not be final. This was causing issues in phpspec which mocks these methods.

This was done for ReflectionFunctionAbstract in #3070 but ReflectionClass was missed

Improved the Zend compatibility for ReflectionClass
inNamespace()`, `getNamespaceName()`, and `getShortName()` should not be `final`. This was causing issues in phpspec which mocks these methods.

stof added a commit to phpspec/prophecy that referenced this pull request Jul 18, 2014

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Jul 18, 2014

This pull request has been imported into Phabricator, and discussion and review of the diff will take place at https://reviews.facebook.net/D20223

This pull request has been imported into Phabricator, and discussion and review of the diff will take place at https://reviews.facebook.net/D20223

@stof stof deleted the stof:patch-1 branch Aug 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment