Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Memcached::setOption for OPT_LIBKETAMA_COMPATIBLE #4364

Closed
wants to merge 3 commits into from

Commits on Dec 1, 2014

  1. Fix Memcached::setOption for OPT_LIBKETAMA_COMPATIBLE

    Summary: The current implementation is missing an if-statement which causes
    the option to be unset even when a truthy value is passed in. The comment
    directly above this block describes the correct behavior. See the original PHP
    implementation for reference: http://goo.gl/7p7WqP. A new constant
    Memcached::DISTRIBUTION_CONSISTENT_KETAMA is added for the sake of testing.
    adsr committed Dec 1, 2014
    Copy the full SHA
    52958c6 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2014

  1. Add option Memcached::DISTRIBUTION_CONSISTENT_KETAMA and fix test

    Summary: The test in the previous commit was checking for the wrong constant.
    I think I was testing against an old libmemcached. Also the addServer line is
    removed because the test does not actually make any network calls.
    adsr committed Dec 2, 2014
    Copy the full SHA
    9d644d8 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2014

  1. Wrap MEMCACHED_DISTRIBUTION_CONSISTENT_WEIGHTED in ifdef and skipif f…

    …or test
    
    in case we're building against an old version of libmemcached.
    adsr committed Dec 10, 2014
    Copy the full SHA
    752c7fb View commit details
    Browse the repository at this point in the history